[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#31742: 26.1.50; excorporate.elc byte-compiled in Emacs 25.x fails in
From: |
Thomas Fitzsimmons |
Subject: |
bug#31742: 26.1.50; excorporate.elc byte-compiled in Emacs 25.x fails in Emacs 26.1 |
Date: |
Fri, 08 Jun 2018 10:18:18 -0400 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.1.50 (gnu/linux) |
(CCing Alex Harsanyi.)
Noam Postavsky <npostavs@gmail.com> writes:
> Thomas Fitzsimmons <fitzsim@fitzsim.org> writes:
>
>> Noam Postavsky <npostavs@gmail.com> writes:
>>
>>> Thomas Fitzsimmons <fitzsim@fitzsim.org> writes:
>>>
>>>> (defun soap-resolve-references (element wsdl)
>>>
>>>> (let ((resolver (get (aref element 0) 'soap-resolve-references)))
>>>
>>> Ah, then it should work to replace the (aref element 0) with (type-of
>>> element) as long as cl-old-struct-compat-mode is enabled.
>>
>> Yes, I retested with that change and it does work. I guess I should
>> submit a patch to change all those occurrences in soap-client.
>
> I just noticed soap-client is also an ELPA package; then there is the
> additional complication that type-of will give the wrong answer in Emacs
> versions 25 and older. So you would need something like
>
> (let ((type (type-of element)))
> (if (eq type 'vector)
> (aref element 0) ; For Emacs 25 and earlier.
> type))
OK, I had that on my list to investigate before patching soap-client,
the compatibility range of type-of, but you've done it for me, thanks.
A soap-type-of compatibility function probably makes sense to replace
the (aref ... 0) occurrences in soap-client and soap-inspect.
>> I'm hoping cl-old-struct-compat-mode will continue to be enabled by
>> default for a long time.
>
> I was going to say, it's currently not enabled by default, but it looks
> like it gets enabled automagically when you load code from the old
> cl-defstruct:
>
> (defun cl-struct-define (name docstring parent type named slots
> children-sym
> tag print)
> (unless type
> ;; Legacy defstruct, using tagged vectors. Enable backward
> compatibility.
> (cl-old-struct-compat-mode 1))
Ah, great, so that logic can stay in Emacs indefinitely without
negatively affecting sessions that don't load old byte-code.
Thomas
- bug#31742: 26.1.50; excorporate.elc byte-compiled in Emacs 25.x fails in Emacs 26.1, Thomas Fitzsimmons, 2018/06/06
- bug#31742: 26.1.50; excorporate.elc byte-compiled in Emacs 25.x fails in Emacs 26.1, Noam Postavsky, 2018/06/06
- bug#31742: 26.1.50; excorporate.elc byte-compiled in Emacs 25.x fails in Emacs 26.1, Thomas Fitzsimmons, 2018/06/06
- bug#31742: 26.1.50; excorporate.elc byte-compiled in Emacs 25.x fails in Emacs 26.1, Noam Postavsky, 2018/06/07
- bug#31742: 26.1.50; excorporate.elc byte-compiled in Emacs 25.x fails in Emacs 26.1, Thomas Fitzsimmons, 2018/06/07
- bug#31742: 26.1.50; excorporate.elc byte-compiled in Emacs 25.x fails in Emacs 26.1, Noam Postavsky, 2018/06/07
- bug#31742: 26.1.50; excorporate.elc byte-compiled in Emacs 25.x fails in Emacs 26.1, Thomas Fitzsimmons, 2018/06/07
- bug#31742: 26.1.50; excorporate.elc byte-compiled in Emacs 25.x fails in Emacs 26.1, Noam Postavsky, 2018/06/07
- bug#31742: 26.1.50; excorporate.elc byte-compiled in Emacs 25.x fails in Emacs 26.1, Thomas Fitzsimmons, 2018/06/07
- bug#31742: 26.1.50; excorporate.elc byte-compiled in Emacs 25.x fails in Emacs 26.1, Noam Postavsky, 2018/06/08
- bug#31742: 26.1.50; excorporate.elc byte-compiled in Emacs 25.x fails in Emacs 26.1,
Thomas Fitzsimmons <=
- bug#31742: 26.1.50; excorporate.elc byte-compiled in Emacs 25.x fails in Emacs 26.1, Alex Harsanyi, 2018/06/09
- bug#31742: 26.1.50; excorporate.elc byte-compiled in Emacs 25.x fails in Emacs 26.1, Thomas Fitzsimmons, 2018/06/08
- bug#31742: 26.1.50; excorporate.elc byte-compiled in Emacs 25.x fails in Emacs 26.1, Alex Harsanyi, 2018/06/09
- bug#31742: 26.1.50; excorporate.elc byte-compiled in Emacs 25.x fails in Emacs 26.1, Thomas Fitzsimmons, 2018/06/09
- bug#31742: 26.1.50; excorporate.elc byte-compiled in Emacs 25.x fails in Emacs 26.1, Thomas Fitzsimmons, 2018/06/11
- bug#31742: 26.1.50; excorporate.elc byte-compiled in Emacs 25.x fails in Emacs 26.1, Eli Zaretskii, 2018/06/12
- bug#31742: 26.1.50; excorporate.elc byte-compiled in Emacs 25.x fails in Emacs 26.1, Thomas Fitzsimmons, 2018/06/12
- bug#31742: 26.1.50; excorporate.elc byte-compiled in Emacs 25.x fails in Emacs 26.1, Alex Harsanyi, 2018/06/16
- bug#31742: 26.1.50; excorporate.elc byte-compiled in Emacs 25.x fails in Emacs 26.1, Thomas Fitzsimmons, 2018/06/16
- bug#31742: 26.1.50; excorporate.elc byte-compiled in Emacs 25.x fails in Emacs 26.1, Alex Harsanyi, 2018/06/16