[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#32024: 27.0; [PATCH] `imenu--generic-function'
From: |
Eli Zaretskii |
Subject: |
bug#32024: 27.0; [PATCH] `imenu--generic-function' |
Date: |
Sat, 07 Jul 2018 12:18:29 +0300 |
> Date: Sat, 30 Jun 2018 15:53:22 -0700 (PDT)
> From: Drew Adams <drew.adams@oracle.com>
>
> Attached is a patch for two bugs in `imenu--generic-function'. I ran
> into them when using a function value for argument REGEXP, though
> neither has to do particularly with that use case. Instead, they both
> have to do with the case where items are within comments or strings,
> which might be skipped.
>
> 1. When checking whether the current item is inside a comment or string,
> it's necessary to first move point to position START. Otherwise, the
> test is made at bol (which might not be within a comment or string,
> even though the START position is).
>
> 2. At the end, it's necessary to remove any empty menus that could have
> been added. That can happen because of skipping things inside
> comments or strings.
Thanks.
Applying this produces the following warning from the byte compiler:
In end of data:
imenu.el:1056:1:Warning: the function `imenup-delete-if-not' is not known to
be defined.
And indeed, I cannot find that function anywhere in Emacs.
- bug#32024: 27.0; [PATCH] `imenu--generic-function',
Eli Zaretskii <=