bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#32276: char-width of a space is 0 when display-table entry has a fac


From: Paul Eggert
Subject: bug#32276: char-width of a space is 0 when display-table entry has a face.
Date: Sat, 28 Jul 2018 15:37:50 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1

Unfortunately that change causes the emacs-26 build to fail for me:

make[1]: Entering directory '/home/eggert/src/gnu/emacs/emacs-26-sc/src'
  CC       character.o
In file included from character.c:34:0:
character.c: In function ‘char_width’:
lisp.h:1682:11: error: ‘c’ may be used uninitialized in this function [-Werror=maybe-uninitialized]
    ? ((a) + (unsigned) 0) op ((b) + (unsigned) 0)   \
           ^
character.c:292:10: note: ‘c’ was declared here
      int c;
          ^
cc1: all warnings being treated as errors
Makefile:376: recipe for target 'character.o' failed


Although the attached patch fixes this and presumably speeds up the code a bit when optimized, is this the right thing to do? I have not looked into the code carefully.

Attachment: 0001-Adjust-recent-Bug-32276-fix.patch
Description: Text Data


reply via email to

[Prev in Thread] Current Thread [Next in Thread]