[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#24150: 26.0.50; New command: dired-create-empty-file
From: |
Tino Calancha |
Subject: |
bug#24150: 26.0.50; New command: dired-create-empty-file |
Date: |
Wed, 01 Aug 2018 14:16:54 +0900 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) |
Eli Zaretskii <eliz@gnu.org> writes:
>
> No, that's not what I meant. I meant to say that if we call
> dired--find-topmost-parent-dir to update the new entry in the Dired
> buffer, then the doc string of dired-create-empty-file should say that
> it does so. Right now, the doc string says just this:
>
> Create an empty file called FILE.
>
> It says nothing about Dired entries.
>
>> I have added the following comment:
>> +;; We use this function in `dired-create-directory' and
>> +;; `dired-create-empty-file'; the return value is the new entry
>> +;; in the updated Dired buffer.
>
> That's fine. But my comment was about the doc string of
> dired-create-empty-file.
Ahhhh, I see.
Hummmm, I think we assume that Dired will add the new entry;
similarly as `dired-do-delete', which deletes the file and
the entry from the Dired buffer: in the docstring it's not mentioned
that this command drop the entry as well.
It's not mentioned in `dired-create-directory' either.
Every command prefixed with 'dired-' should add/drop buffer entries
automatically as needed.
I think this last sentence belongs to the manual more than the
docstrings (probably already there).
- bug#24150: 26.0.50; New command: dired-create-empty-file,
Tino Calancha <=