bug#33344: 26.1; doc-view bounding-box recognition doesn't work on path names with spaces

[Glenn Morris]

Robert Spillner wrote:

> in doc-view.el, line 1215, ghostscript is called via shell to grep the
> bounding box of a ps or pdf-file. In line 1218, the last %s
> (representing the filename) is used unquoted. Therefore, whenever the
> filename or the directory pointing to this file has spaces in its name
> gs won't be able to find it and determine a bounding box.
>
> Please change line 1218 from
>
>   (format "-dFirstPage=%s -dLastPage=%s %s"
>
> to
>
>   (format "-dFirstPage=%s -dLastPage=%s \"%s\""

Thanks for the report.
I don't see a need for the shell to be involved at all here.
The following seems to work for me - how about for you?


--- i/lisp/doc-view.el
+++ w/lisp/doc-view.el
@@ -1204,25 +1204,30 @@ doc-view-set-slice-using-mouse
 
 (defun doc-view-get-bounding-box ()
   "Get the BoundingBox information of the current page."
-  (let* ((page (doc-view-current-page))
-        (doc (let ((cache-doc (doc-view-current-cache-doc-pdf)))
-               (if (file-exists-p cache-doc)
-                   cache-doc
-                 doc-view--buffer-file-name)))
-        (o (shell-command-to-string
-            (concat doc-view-ghostscript-program
-                    " -dSAFER -dBATCH -dNOPAUSE -q -sDEVICE=bbox "
-                    (format "-dFirstPage=%s -dLastPage=%s %s"
-                            page page doc)))))
-    (save-match-data
-      (when (string-match (concat "%%BoundingBox: "
-                                 "\\([[:digit:]]+\\) \\([[:digit:]]+\\) "
-                                 "\\([[:digit:]]+\\) \\([[:digit:]]+\\)") o)
-       (mapcar #'string-to-number
-               (list (match-string 1 o)
-                     (match-string 2 o)
-                     (match-string 3 o)
-                     (match-string 4 o)))))))
+  (let ((page (doc-view-current-page))
+       (doc (let ((cache-doc (doc-view-current-cache-doc-pdf)))
+              (if (file-exists-p cache-doc)
+                  cache-doc
+                doc-view--buffer-file-name))))
+    (with-temp-buffer
+      (when (eq 0 (ignore-errors
+                   (call-process doc-view-ghostscript-program nil t
+                                 nil "-dSAFER" "-dBATCH" "-dNOPAUSE" "-q"
+                                 "-sDEVICE=bbox"
+                                 (format "-dFirstPage=%s" page)
+                                 (format "-dLastPage=%s" page)
+                                 doc)))
+       (goto-char (point-min))
+       (save-match-data
+         (when (re-search-forward
+                (concat "%%BoundingBox: "
+                        "\\([[:digit:]]+\\) \\([[:digit:]]+\\) "
+                        "\\([[:digit:]]+\\) \\([[:digit:]]+\\)") nil t)
+           (mapcar #'string-to-number
+                   (list (match-string 1)
+                         (match-string 2)
+                         (match-string 3)
+                         (match-string 4)))))))))
 
 (defvar doc-view-paper-sizes
   '((a4 595 842)