bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#33498: 26.1; Unable to delete minibuffer-only+child frames


From: Paul Eggert
Subject: bug#33498: 26.1; Unable to delete minibuffer-only+child frames
Date: Wed, 6 Mar 2019 11:07:14 -0800
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.5.1

> I think I fixed this now on master.  Please have a look.

Unfortunately the fix broke builds configured with
--enable-gcc-warnings, as GCC complains about the use of an
uninitialized variable that appears to be a typo in the fix. I installed
the attached patch to unbreak the build; please check it to make sure
that I understood the intent of the fix correctly.

It's a good idea to use './configure --enable-gcc-warnings' when making
changes to the C code in Emacs, as GCC is reasonably good at catching
typos like this, and typically does not generate too many false alarms.

Attachment: 0001-Fix-typo-in-fix-for-Bug-33498.patch
Description: Text Data


reply via email to

[Prev in Thread] Current Thread [Next in Thread]