|
From: | Daniel Colascione |
Subject: | bug#34910: 27.0.50; Too much matching reentrancy |
Date: | Sat, 30 Mar 2019 07:52:12 -0700 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.5.1 |
On 3/30/19 4:18 AM, Mattias Engdegård wrote:
30 mars 2019 kl. 10.30 skrev Eli Zaretskii <eliz@gnu.org>:Here is another improvement: there should be no reason to keep the regexp busy during the overflow error processing, so release it first.Looks OK to me.Thank you, both pushed.
Thanks!
By the way, is there any reason why only calls to re_search_2 are made with a busy-marked regexp buffer, not calls to re_search? Are the latter guaranteed not to be reentrant?Not sure. Stefan, any thoughts?Maybe Daniel only had reentrancy concerns about regexp matching on buffers, not on strings?
We do automatic syntax discovery on buffers, not strings.
[Prev in Thread] | Current Thread | [Next in Thread] |