[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#33225: [debbugs.el] Don't send control message immediately
From: |
Michael Albinus |
Subject: |
bug#33225: [debbugs.el] Don't send control message immediately |
Date: |
Sun, 31 Mar 2019 12:21:29 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) |
Noam Postavsky <npostavs@gmail.com> writes:
Hi Noam,
Thanks for the patch. In general, it works fine, so I guess you could
push it. We (I)'ll play then for some days, and if there's no serious
complaint, I'll make a new debbugs release.
But I still have some comments :-)
Please rename
debbugs-control-make-message → debbugs-gnu-make-control-message
debbugs-control-message-keywords → debbugs-gnu-control-message-keywords
debbugs-control-message-commands-regexp →
debbugs-gnu-control-message-commands-regexp
debbugs-control-message-end-regexp → debbugs-gnu-control-message-end-regexp
Please add (the keybindings of) debbugs-gnu-make-control-message to the
Commentary sections of debbugs-gnu.el and debbugs-org.el and to the nodes
"Tabulated Lists" and "TODO Items" of debbugs-ug.texi.
Compiling debbugs-gnu.el results in
debbugs-gnu.el:1534:1:Warning: Unused lexical variable ‘addr’
debbugs-gnu.el:1552:1:Warning: Unused lexical variable ‘micro’
debbugs-gnu.el:1552:1:Warning: Unused lexical variable ‘subject’
Maybe you can fix it?
> Added, though it looks like the .info file is also in git? I haven't
> regenerated it since I use texinfo 4.13, so that would trigger all sorts
> of spurious changes.
Yes, unfortunately, the info file must be there. Don't worry about, I'll
regenerate.
> +(defconst debbugs-control-message-keywords
> + '("serious" "important" "normal" "minor" "wishlist"
> + "done" "donenotabug" "donewontfix" "doneunreproducible"
> + "invalid" ; done+notabug+wontfix
> + "unarchive" "unmerge" "reopen" "close"
> + "merge" "forcemerge"
> + "block" "unblock"
> + "owner" "noowner"
> + "reassign"
> + "retitle"
> + "forwarded" "notforwarded"
> + ;; 'notfixed <bugnum> <version>' works, even though it's
> + ;; undocumented at debbugs.gnu.org.
> + "fixed" "found" "notfound" "notfixed"
> + "patch" "wontfix" "moreinfo" "unreproducible" "notabug"
> + "pending" "help" "security" "confirmed" "easy"
> + "usertag" "user"
> + "documentation" ;; usertag:emacs.documentation
> + ))
I suppose "user" is needed in case of debbugs-gnu-make-control-message
only. Could we separate this, and offer completion only for that
function?
> + ((member message '("merge" "forcemerge"))
> + (format "%s %d %s\n" message bugid
> + (read-string "Merge with bug #: ")))
You have removed the bug number completion via
debbugs-gnu-expand-bug-number-list. Why?
> + ((member message '("block" "unblock"))
> + (format
> + "%s %d by %s\n" message bugid
> + (mapconcat
> + 'identity
> + (completing-read-multiple
> + (format "%s with bug(s) #: " (capitalize message))
> + (if (equal message "unblock")
> + (mapcar 'number-to-string
> + (cdr (assq 'blockedby status))))
> + nil (and (equal message "unblock") status))
> + " ")))
dito
> +@item user
> +"user @var{username}"
> +
> +The username, read interactively, is either a package name or an email
> +address.
Please mention, that this is used in order to avoid giving the user name
again, for further commands.
Best regards, Michael.