[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#35062: [PATCH 0/4] Trivial code cleanups
From: |
Konstantin Kharlamov |
Subject: |
bug#35062: [PATCH 0/4] Trivial code cleanups |
Date: |
Mon, 1 Apr 2019 01:37:38 +0300 |
These are mostly fixes of some of LGTM warnings
https://lgtm.com/projects/g/emacs-mirror/emacs/alerts/?mode=tree
Except the second patch, where I initially wanted to fix one warning,
and as part of it I had to constify a variable to see that it is indeed
immutable. And then I figured I could search through the code and find
more similar places, where variables weren't marked as const. I like
this cleanup because it is simple and trivially testable (i.e. if it
compiles, then it's fine). FTR: there's still lots of opportunities for
constification, I just stopped at some point.
Konstantin Kharlamov (4):
Remove redundant comparison
constify a bit of xterm.c
min_cols/rows is always 0, don't check for it
don't compare unsigned to less-than-zero
src/gtkutil.c | 5 +----
src/pdumper.c | 2 --
src/xterm.c | 34 +++++++++++++++++-----------------
3 files changed, 18 insertions(+), 23 deletions(-)
--
2.21.0