[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#20150: 24.4: bookmarks: return from editing annotations (FIX INCLUDE
From: |
Stefan Kangas |
Subject: |
bug#20150: 24.4: bookmarks: return from editing annotations (FIX INCLUDED) |
Date: |
Sat, 13 Jul 2019 15:09:39 +0200 |
Eli Zaretskii <eliz@gnu.org> writes:
> > +(define-obsolete-variable-alias 'bookmark-annotation-name
> > + 'bookmark-annotation--name "27.1")
>
> Hmm... we declare a non-internal variable obsolete and replace it with
> an internal variable? Why is that a good idea? Does the new variable
> have to be internal?
I thought about it a bit more, and I guess it doesn't have to be internal. I
suggest that the new variable should be kept internal for now though.
I also don't know why I named the new variable bookmark-annotation--name, so
I've changed that to bookmark--annotation-name to better reflect current
practices.
Please see this updated patch with those two changes.
Thanks,
Stefan Kangas
0001-Restore-focus-to-Bookmark-List-after-editing-annotat.patch
Description: Text Data
- bug#20150: 24.4: bookmarks: return from editing annotations (FIX INCLUDED), Stefan Kangas, 2019/07/01
- bug#20150: 24.4: bookmarks: return from editing annotations (FIX INCLUDED), Stefan Kangas, 2019/07/01
- bug#20150: 24.4: bookmarks: return from editing annotations (FIX INCLUDED), Stefan Kangas, 2019/07/03
- bug#20150: 24.4: bookmarks: return from editing annotations (FIX INCLUDED), Stefan Kangas, 2019/07/04
- bug#20150: 24.4: bookmarks: return from editing annotations (FIX INCLUDED), Stefan Kangas, 2019/07/04
- bug#20150: 24.4: bookmarks: return from editing annotations (FIX INCLUDED), Eli Zaretskii, 2019/07/13
- bug#20150: 24.4: bookmarks: return from editing annotations (FIX INCLUDED),
Stefan Kangas <=
- bug#20150: 24.4: bookmarks: return from editing annotations (FIX INCLUDED), Eli Zaretskii, 2019/07/13
- bug#20150: 24.4: bookmarks: return from editing annotations (FIX INCLUDED), Stefan Kangas, 2019/07/13
- bug#20150: 24.4: bookmarks: return from editing annotations (FIX INCLUDED), Glenn Morris, 2019/07/13
- bug#20150: 24.4: bookmarks: return from editing annotations (FIX INCLUDED), Eli Zaretskii, 2019/07/14
- bug#20150: 24.4: bookmarks: return from editing annotations (FIX INCLUDED), Eli Zaretskii, 2019/07/14