[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#35564: [PATCH v4] Tweak dired warning about "wildcard" characters
From: |
Kévin Le Gouguec |
Subject: |
bug#35564: [PATCH v4] Tweak dired warning about "wildcard" characters |
Date: |
Sat, 27 Jul 2019 19:26:25 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) |
Eli Zaretskii <eliz@gnu.org> writes:
>> From: Kévin Le Gouguec <kevin.legouguec@gmail.com>
>> Cc: Eli Zaretskii <eliz@gnu.org>, Stefan Monnier
>> <monnier@iro.umontreal.ca>, Drew Adams <drew.adams@oracle.com>, Noam
>> Postavsky <npostavs@gmail.com>
>> Date: Fri, 12 Jul 2019 17:10:26 +0200
>>
>> I have now added '^' markers below the highlighted command, on condition
>> that the echo area is wide enough not to wrap lines.
>>
>> Do we want to add some customizability (highlight face, whether or not
>> to display '^' markers), or is this good enough for now?
>>
>>
>> The patch series now includes:
>>
>> - two patches to make y-or-n-p preserve text properties and implement an
>> initial version of highlighting,
>> - Noam's refactoring patch, plus fixups,
>> - one patch to add '^' markers,
>> - one last patch to make tests less tedious to maintain.
>
> Any more comments, anyone?
Michael had some comments over at bug#28969, but no objections AFAICT.
Michael, did you get the chance to try the patch out?
> Is there anything in these changes that would warrant a NEWS entry?
The changes are only cosmetic: the user interaction has not changed
(tell Dired to run a command, press 'y' to confirm). The prompt is
simply more verbose now.
There are no new variables for the user to customize either, if I am not
mistaken.
NB: I squashed all those patches in [2], to make it easier to try the
new prompt out. The squashed patch's commit message summarizes every
change, and mentions both bugs; I don't know if it makes more sense to
commit the series or the squashed patch to the repository.
[1] https://debbugs.gnu.org/cgi/bugreport.cgi?bug=28969#22
[2] https://debbugs.gnu.org/cgi/bugreport.cgi?bug=28969#19