bug#22243: eieio-opt: not quite (?) optional functions

[Lars Ingebrigtsen]

Ivan Shmakov <ivan@siamics.net> writes:

>       eieio.el currently (1dcf9a5d2a72; 2015-12-22 17:02:30 UTC)
>       reads:
>
>    943        ;; Hook ourselves into help system for describing classes and 
> methods.
>    944        ;; FIXME: This is not actually needed any more since we can 
> click on the
>    945        ;; hyperlink from the constructor's docstring to see the type 
> definition.
>    946        (add-hook 'help-fns-describe-function-functions 
> 'eieio-help-constructor)
>
>       This results that with -Q, 'eieio-opt gets loaded immediately
>       once the user tries to use the Emacs help system (say, C-h f),
>       making the file’s description (below) somewhat misleading, as
>       the library which is hooked into such a basic Emacs facility
>       could hardly be called “optional”.

If comment about this not being needed was added in 2015 by Stefan.  But
it says that it's "actually" not needed, and "actually not" in common
usage means "absolutely is", so that's quite confusing.

But if it's not needed, then it sounds like we should remove it?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no