[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#36707: [PATCH] Signal user-error on duplicate package refresh
From: |
Stefan Kangas |
Subject: |
bug#36707: [PATCH] Signal user-error on duplicate package refresh |
Date: |
Mon, 12 Aug 2019 02:35:28 +0200 |
Noam Postavsky <npostavs@gmail.com> writes:
> "Basil L. Contovounesios" <contovob@tcd.ie> writes:
>
> > Stefan Kangas <stefan@marxist.se> writes:
> >
> >> In the "*Packages*" buffer (M-x package-list-packages), if I hit "r" many
> >> times
> >> it will try to initiate more refreshes even if the first one has not
> >> finished
> >> yet. This is unnecessary and potentially confusing.
> >>
> >> This patch makes it check if there is already an refresh in progress and
> >> signal
> >> a user-error if there is one.
> >
> > Would it not be possible/better to discard the existing refresh and
> > start a new one, instead of signalling an error? This would help
> > e.g. when a refresh hangs for whatever reason.
>
> Not sure if it's better, supposing the user is hitting "r" repeatedly,
> that just interrupts the pending refreshes, preventing any progress. I
> would expect hanging to be cancelled by a timeout anyway.
I agree with Noam that a timeout would make more sense. Not sure if
it already exists or if that's a separate issue.
Thanks,
Stefan Kangas