[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#36603: [PATCH] Simplify calling convention of describe_map
From: |
Noam Postavsky |
Subject: |
bug#36603: [PATCH] Simplify calling convention of describe_map |
Date: |
Tue, 20 Aug 2019 12:00:35 -0400 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.1.92 (windows-nt) |
Noam Postavsky <npostavs@gmail.com> writes:
> Stefan Kangas <stefan@marxist.se> writes:
>
>> + Lisp_Object seen_orig = Qnil;
>> + Lisp_Object *seen = &seen_orig;
>
> Do we really need the seen_orig variable? It looks like there is no
> reason for having seen as a pointer at all, but maybe I'm missing
> something.
Actually, maybe the patch is wrong (i.e., over-simplifying), because it
has describe_map start with a fresh seen pointer each time; but the
current code passes the same pointer to each describe_map call in a
loop.