[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#34720: 26.1; Reverting a GPG buffer moves all markers to the end of
From: |
Lars Ingebrigtsen |
Subject: |
bug#34720: 26.1; Reverting a GPG buffer moves all markers to the end of the file |
Date: |
Tue, 27 Aug 2019 11:05:33 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) |
Eli Zaretskii <eliz@gnu.org> writes:
> Must be sheer luck. Or maybe I'm missing something, but you will have
> to show me the code that moves this test marker to convince me. (I
> don't have the necessary software installed to repeat the recipe myself.)
(progn
(find-file "/tmp/foo.txt")
(kill-buffer (current-buffer))
(when (file-exists-p "/tmp/foo.txt")
(delete-file "/tmp/foo.txt"))
(find-file "/tmp/foo.txt")
(insert "Test line.")
(setq test-marker1 (make-marker))
(move-marker test-marker1 4)
(setq test-marker2 (make-marker))
(move-marker test-marker2 5)
(save-buffer t)
(shell-command "echo new >> /tmp/foo.txt")
(revert-buffer nil t)
(list test-marker1 test-marker2))
=> (#<marker at 4 in foo.txt> #<marker at 5 in foo.txt>)
So the markers seem to be restored on `revert-buffer'?
The reason this doesn't happen in the epa case seems to be a bug in
Finsert_file_contents: When there's an external handler, it skips
directly to handled: and neglects to do the same_at_start computation,
which leaves that at point-min and restore_window_points ignores all
markers that have values that are larger than same_at_start.
If I'm reading the code right.
If the new text doesn't match the old text, the markers are not
restored:
(progn
(find-file "/tmp/foo.txt")
(kill-buffer (current-buffer))
(when (file-exists-p "/tmp/foo.txt")
(delete-file "/tmp/foo.txt"))
(find-file "/tmp/foo.txt")
(insert "Test line.")
(setq test-marker1 (make-marker))
(move-marker test-marker1 4)
(setq test-marker2 (make-marker))
(move-marker test-marker2 5)
(save-buffer t)
(shell-command "echo Here is a new text > /tmp/foo.txt")
(revert-buffer nil t)
(list test-marker1 test-marker2))
(#<marker at 1 in foo.txt> #<marker at 1 in foo.txt>)
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
- bug#34720: 26.1; Reverting a GPG buffer moves all markers to the end of the file, Lars Ingebrigtsen, 2019/08/26
- bug#34720: 26.1; Reverting a GPG buffer moves all markers to the end of the file, Eli Zaretskii, 2019/08/26
- bug#34720: 26.1; Reverting a GPG buffer moves all markers to the end of the file, Lars Ingebrigtsen, 2019/08/26
- bug#34720: 26.1; Reverting a GPG buffer moves all markers to the end of the file, Eli Zaretskii, 2019/08/26
- bug#34720: 26.1; Reverting a GPG buffer moves all markers to the end of the file, Lars Ingebrigtsen, 2019/08/27
- bug#34720: 26.1; Reverting a GPG buffer moves all markers to the end of the file, Eli Zaretskii, 2019/08/27
- bug#34720: 26.1; Reverting a GPG buffer moves all markers to the end of the file, Lars Ingebrigtsen, 2019/08/27
- bug#34720: 26.1; Reverting a GPG buffer moves all markers to the end of the file, Eli Zaretskii, 2019/08/27
- bug#34720: 26.1; Reverting a GPG buffer moves all markers to the end of the file,
Lars Ingebrigtsen <=
- bug#34720: 26.1; Reverting a GPG buffer moves all markers to the end of the file, Eli Zaretskii, 2019/08/27
- bug#34720: 26.1; Reverting a GPG buffer moves all markers to the end of the file, Lars Ingebrigtsen, 2019/08/27
- bug#34720: 26.1; Reverting a GPG buffer moves all markers to the end of the file, Eli Zaretskii, 2019/08/27
- bug#34720: 26.1; Reverting a GPG buffer moves all markers to the end of the file, Lars Ingebrigtsen, 2019/08/30
- bug#34720: 26.1; Reverting a GPG buffer moves all markers to the end of the file, Lars Ingebrigtsen, 2019/08/30
- bug#34720: 26.1; Reverting a GPG buffer moves all markers to the end of the file, Eli Zaretskii, 2019/08/30
- bug#34720: 26.1; Reverting a GPG buffer moves all markers to the end of the file, Lars Ingebrigtsen, 2019/08/27