[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#36981: 26.2; request: add searching by package name to list-packages
From: |
Štěpán Němec |
Subject: |
bug#36981: 26.2; request: add searching by package name to list-packages |
Date: |
Sun, 08 Sep 2019 17:20:00 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) |
I don't use package.el, but here are a few observations:
> From: Federico Tedin <federicotedin@gmail.com>
> Date: Sun, 8 Sep 2019 02:38:43 +0200
> Subject: [PATCH 1/1] Search packages by name in list-packages (Bug#36981)
>
> + (if (or keywords (and packages (listp packages)))
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AKA "(consp packages)", though maybe you find your version more
descriptive.
> +(defun package-menu-search (name)
> + "Filter the *Packages* buffer.
> +Show only those items whose name matches NAME. If NAME is nil or an
> +empty string, show all packages.
If I was reading it as a user, I would appreciate it if the doc string
was more specific regarding the NAME argument, e.g. said "matches the
regular expression NAME" or something to that effect.
Also, I think "empty string" is usually prefixed with "the", not "an",
as there is only one such thing, e.g. (eq "" "") => t.
> +To restore the full package list, type `q'."
> + (interactive
> + (list (read-from-minibuffer "Package name: ")
> + current-prefix-arg))
^^^^^^^^^^^^^^^^^^
Is this a remnant of some previous WIP version? The function now takes a
single argument, right?
Thanks!
--
Štěpán
- bug#36981: 26.2; request: add searching by package name to list-packages, Federico Tedin, 2019/09/07
- bug#36981: 26.2; request: add searching by package name to list-packages,
Štěpán Němec <=
- bug#36981: 26.2; request: add searching by package name to list-packages, Stefan Kangas, 2019/09/15
- bug#36981: 26.2; request: add searching by package name to list-packages, Federico Tedin, 2019/09/18
- bug#36981: 26.2; request: add searching by package name to list-packages, Stefan Kangas, 2019/09/18
- bug#36981: 26.2; request: add searching by package name to list-packages, Juri Linkov, 2019/09/19
- bug#36981: 26.2; request: add searching by package name to list-packages, Federico Tedin, 2019/09/20
- bug#36981: 26.2; request: add searching by package name to list-packages, Stefan Kangas, 2019/09/20
- bug#36981: 26.2; request: add searching by package name to list-packages, Federico Tedin, 2019/09/26