bug#37215: [PATCH] vc-cvs-ignore writes absolute filenames and duplicate strings

[Lars Ingebrigtsen]

Wolfgang Scherer <Wolfgang.Scherer@gmx.de> writes:

> * lisp/vc/vc-cvs.el: (vc-cvs-ignore) Expand filename correctly
> and pass on basename only.
> (vc-cvs-append-to-ignore) Do not write duplicate strings to
> .cvsignore.

This looks correct to me, but:

[...]

> +        ;; FIXME this is a pcvs variable.
> +        (if (bound-and-true-p cvs-sort-ignore-file)
> +            (sort-lines nil (point-min) (point-max)))

Does it make sense to heed a pcvs variable here?  I think it would be
surprising that vc-cvs behaves differently depending on whether you've
loaded pcvs or not.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no