bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#37344: rcirc: nil gets interpreted as a nickname


From: Lars Ingebrigtsen
Subject: bug#37344: rcirc: nil gets interpreted as a nickname
Date: Fri, 20 Sep 2019 20:33:18 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux)

Leo Liu <sdl.web@gmail.com> writes:

> Thanks. Does the following patch fix the issue?

It was confirmed that it does, so I guess you should just apply the
patch, but:


[...]

> -(defun rcirc-cmd-me (args &optional process target)
> -  (rcirc-send-ctcp process target "ACTION" args))
> +(defun rcirc-cmd-me (args process target)
> +  (when target (rcirc-send-ctcp process target "ACTION" args)))

Perhaps you should keep the &optional there to avoid changing the call
signature?  Somebody else may have code that calls the function with
that calling convention.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no





reply via email to

[Prev in Thread] Current Thread [Next in Thread]