[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#37202: shadowfile-tests: two failures on macOS
From: |
Paul Eggert |
Subject: |
bug#37202: shadowfile-tests: two failures on macOS |
Date: |
Fri, 20 Sep 2019 12:04:41 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 |
On 9/20/19 5:35 AM, Michael Albinus wrote:
That means, (file-attributes truename) returns nil although
(file-exists-p truename) returns non-nil.
I don't see why the recent changes would cause file-attributes to return nil on
a local file. If file-exists-p succeeds, the file has been confirmed to exist.
In that case, when file-attributes uses fstatat (or openat+stat) the syscalls
should either succeed, or should fail with an unusual errno value like
EOVERFLOW, so file-attributes should either return non-nil or signal an error.
Perhaps the file in question has file handlers that are interposing themselves?
That might explain the situation.
I should mention that under Emacs 26 file-attributes can return nil here, even
for a local file: e.g., (file-exists-p F) uses faccessat which succeeds, then
(file-attributes F) uses fstatat (or openat+fstat) which fails with
errno==EOVERFLOW because F's timestamp or inode number is out of range for the
kernel.
Also, of course using two calls suffers from a race if the filesystem changes
between the calls.
So, regardless of the the recent access changes, it appears that this code in
tramp-handle-file-modes:
(when (file-exists-p truename)
(tramp-mode-string-to-int
(tramp-compat-file-attribute-modes (file-attributes truename))))
should be rewritten to be something like this:
(when-let ((attrs (file-attributes truename)))
(tramp-mode-string-to-int
(tramp-compat-file-attribute-modes attrs)))
- bug#37202: shadowfile-tests: two failures on macOS, (continued)
- bug#37202: shadowfile-tests: two failures on macOS, Stefan Kangas, 2019/09/08
- bug#37202: shadowfile-tests: two failures on macOS, Michael Albinus, 2019/09/13
- bug#37202: shadowfile-tests: two failures on macOS, Stefan Kangas, 2019/09/14
- bug#37202: shadowfile-tests: two failures on macOS, Michael Albinus, 2019/09/15
- bug#37202: shadowfile-tests: two failures on macOS, Stefan Kangas, 2019/09/15
- bug#37202: shadowfile-tests: two failures on macOS, Michael Albinus, 2019/09/16
- bug#37202: shadowfile-tests: two failures on macOS, Glenn Morris, 2019/09/16
- bug#37202: shadowfile-tests: two failures on macOS, Michael Albinus, 2019/09/19
- bug#37202: shadowfile-tests: two failures on macOS, Paul Eggert, 2019/09/19
- bug#37202: shadowfile-tests: two failures on macOS, Michael Albinus, 2019/09/20
- bug#37202: shadowfile-tests: two failures on macOS,
Paul Eggert <=
- bug#37202: shadowfile-tests: two failures on macOS, Michael Albinus, 2019/09/20
- bug#37202: shadowfile-tests: two failures on macOS, Michael Albinus, 2019/09/21