bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#37174: 26.2; Stabilize tabulated-list reversed sort


From: Lars Ingebrigtsen
Subject: bug#37174: 26.2; Stabilize tabulated-list reversed sort
Date: Sat, 21 Sep 2019 00:09:27 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux)

Johan Claesson <johanclaesson@bredband.net> writes:

> Sorting with S multiple times in a tabulated-list buffer should be
> stable but will sometimes reorder entries with the same value.  When the
> sort order is reversed the function tabulated-list--get-sorter will
> transform the sort function to sort the other way around by negating.  I
> think this is what cause the needless reordering and that it should be
> changed something like the following:

[...]

>        (if (cdr tabulated-list-sort-key)
> -          (lambda (a b) (not (funcall sorter a b)))
> +          (lambda (a b) (funcall sorter b a))

That looks like the correct solution, so I've applied it to the trunk.

If I read the logs correctly, I think that cumulatively you've now had
the number of lines committed to Emacs that's allowed without signing
copyright assignment papers.  For future patches, would you be willing
to sign such paperwork?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no





reply via email to

[Prev in Thread] Current Thread [Next in Thread]