bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#6207: 23.1; align.el vhdl rules setup


From: Basil L. Contovounesios
Subject: bug#6207: 23.1; align.el vhdl rules setup
Date: Thu, 26 Sep 2019 13:58:01 +0100
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux)

Stefan Kangas <stefan@marxist.se> writes:

> How about the attached patch?

I haven't followed the discussion, just noticed some minor issues:

>  (defcustom align-dq-string-modes
>    (append align-lisp-modes align-c++-modes align-perl-modes
> -       '(python-mode))
> +       '(python-mode 'vhdl-mode))
                        ^
Stray quote?

> +(make-obsolete-variable 'align-vhdl-rules-list "not used" "27.1")
                                                  ^^^^^^^^^^
This produces the following in *Help*:

  This variable is obsolete since 27.1;
  not used

I think "it is no longer used." or similar, with trailing full stop,
would read better.

>  (defun align-set-vhdl-rules ()
>    "Setup the `align-mode-rules-list' variable for `vhdl-mode'."
> +  (define (obsolete nil "27.1"))
      ^^^^^^
declare?

Thanks,

-- 
Basil





reply via email to

[Prev in Thread] Current Thread [Next in Thread]