[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#5358: 23.1; Adding comment loses customizations in progress
From: |
Lars Ingebrigtsen |
Subject: |
bug#5358: 23.1; Adding comment loses customizations in progress |
Date: |
Fri, 27 Sep 2019 16:09:40 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) |
Mauro Aranda <maurooaranda@gmail.com> writes:
> Subject: [PATCH] Don't discard customizations in progress when adding comments
> (Bug#5358)
Looks good to me. Just one tiny comment:
> + (condition-case nil
> + (let* ((symbol (widget-get widget :value))
> + (get (or (get symbol 'custom-get) 'default-value))
> + (value (if (default-boundp symbol)
> + (funcall get symbol)
> + (symbol-value symbol))))
> + (not (equal value (widget-value (car (widget-get widget
> :children))))))
> + (error t)))
If it's just the funcall you expect that might fail, then moving the
condition-case down there might be a better choice. Having a
condition-case around code that shouldn't fail can hide errors you don't
want to hide.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no