[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#30990: Should the byte compiler warn about :type mismatches?
|
From: |
Lars Ingebrigtsen |
|
Subject: |
bug#30990: Should the byte compiler warn about :type mismatches? |
|
Date: |
Mon, 30 Sep 2019 17:45:39 +0200 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) |
Robert Pluim <rpluim@gmail.com> writes:
> (defcustom winner-boring-buffers-regexp nil
> "`winner-undo' will not restore windows with buffers matching this regexp."
> - :type 'string
> + :type '(choice (string :tag "Regexp")
> + (const :tag "Don't check" nil))
> :version "27.1")
>
> Iʼm not sure those are worth fixing.
I think fixing those would be a win.
> I did spot what seem to be some genuine errors though (hmm, would
> flymake-cc-command need a :version tag update as well? The existing
> definition makes customize error out)
[...]
> - :type 'bool
> + :type 'boolean
etc. Looks good to me; please push.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no