bug#38354: 27.0.50; Implement display action display-buffer-in-tab

[martin rudalics]

>> There is one thing I apparently do not understand yet: When you enable
>> 'tab-bar-mode' it is global
>
> Do you think we should have 'global-tab-bar-mode' for all frames,
> and 'tab-bar-mode' to enable/disable the tab-bar in every frame
> separately?

In the sense that we can enable menu or tool bars for frames
individually?  I think so, yes.

>> - that is any window ever shown on any frame is also in at least one
>> of that frame's tabs.  Is that right?  So what would 'use-tabs' mean
>> here when every window is in a tab already?
>
> These windows in tabs are in window-configurations and window-states.
> Now I installed tab-bar-get-buffer-tab

"Return a tab whose window contains BUFFER-OR-NAME, or nil if none."

is a bit misleading, maybe

"Return a tab with a|owning a window whose buffer is BUFFER-OR-NAME."

is better.  Also the 'lambda's following the 'seq-some' should be
moved to a new line to keep line lengths within their limits.

In either case, do I read the code correctly that it can prefer a
window in a non-current tab to a window in a current tab on another
frame.  If so, do we want that?

An aside: Are you sure that 'tab-bar-tabs' should always work on the
selected frame and not take a frame as argument?

> that can be used
> in display-buffer-reuse-window to search the buffer
> in window-states of tabs when use-tabs is non-nil.

Given my observation above, this can make a tab current in frame A
although the current tab of frame B already shows the buffer.  Right?

>>>     By default, a new tab starts with the buffer that was current
>>>     before calling the command that adds a new tab.
>>
>> The current buffer is IMHO a much too obscure object to consider here.
>> Don't you mean the buffer of the selected window?
>
> The manual refers to the default value of tab-bar-new-tab-choice
> with its docstring:
>
>    If t, start a new tab with the current buffer, i.e. the buffer
>    that was current before calling the command that adds a new tab
>    (this is the same what `make-frame' does by default).

OK.  Then my next nitpick is that the doc-string of
'tab-bar-new-tab-choice' says

If the value is a string, use it as a buffer name switch to a buffer

which apparently should have "... name.  Switch ..." instead.

martin