bug#38577: 27.0.50; eshell / make-symbolic-link: cp -a fails on symlinks

[Jose A. Ortega Ruiz]

This problem is present in 26.3 and latest master branch, i haven't
tried with earilier versions.  To reproduce:

   - emacs -Q
   - M-x eshell, and there:

       ~ $ touch foo
       ~ $ ln -s foo bar
       ~ $ cp -a bar foo
       Wrong number of arguments: #<subr make-symbolic-link>, 4
       ~ $ 

Thanks!


In GNU Emacs 27.0.50 (build 13, x86_64-pc-linux-gnu)
 of 2019-12-09 built on osgiliath
Repository revision: 51176ee81e8e773d8b6ac06dd153846abee0c0f4
Repository branch: master
Windowing system distributor 'The X.Org Foundation', version 11.0.12006000
System Description: Debian GNU/Linux bullseye/sid

Recent messages:
Importing package-keyring.gpg...done
user-error: Package refresh is already in progress, please wait...
Package refresh done
Packages that can be upgraded: 2; type ‘U’ to mark for upgrading.
previous-line: Beginning of buffer
Contacting host: melpa.org:443
Type "q" to restore previous buffer.
mouse-2, RET: Push this button
mouse-2, RET: Describe package [3 times]
mouse-2, RET: view this URL in a browser
scroll-down-command: Beginning of buffer
Configured using:
 'configure --with-x-toolkit=no --prefix=/usr/local/stow/emacs27
 --without-imagemagick --without-cairo'

Configured features:
XPM JPEG TIFF GIF PNG RSVG SOUND DBUS GSETTINGS GLIB NOTIFY INOTIFY
LIBSELINUX GNUTLS LIBXML2 FREETYPE HARFBUZZ M17N_FLT LIBOTF XFT ZLIB
OLDXMENU X11 XDBE XIM MODULES THREADS JSON PDUMPER LCMS2 GMP

Important settings:
  value of $LANG: en_GB.UTF-8
  locale-coding-system: utf-8-unix

Major mode: w3m

Minor modes in effect:
  winner-mode: t
  mpdel-mode: t
  circe-lagmon-mode: t
  tracking-mode: t
  global-magit-file-mode: t
  magit-auto-revert-mode: t
  global-git-commit-mode: t
  async-bytecomp-package-mode: t
  global-diff-hl-mode: t
  pdf-occur-global-minor-mode: t
  display-time-mode: t
  shell-dirtrack-mode: t
  show-paren-mode: t
  which-key-mode: t
  global-auto-revert-mode: t
  persistent-scratch-autosave-mode: t
  display-battery-mode: t
  global-company-mode: t
  ivy-rich-mode: t
  counsel-mode: t
  ivy-mode: t
  savehist-mode: t
  recentf-mode: t
  save-place-mode: t
  override-global-mode: t
  tooltip-mode: t
  global-eldoc-mode: t
  electric-indent-mode: t
  mouse-wheel-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  buffer-read-only: t
  column-number-mode: t
  line-number-mode: t

Load-path shadows:
/home/jao/.emacs.d/elpa.27/tuareg-20191211.1610/dot-emacs hides 
/home/jao/lib/elisp/jao/bmk/dot-emacs

Features:
(shadow emacsbug enwc-nm xt-mouse w3m-save flow-fill log-view pdf-sync
pdf-annot pdf-outline pdf-links pdf-history paradox paradox-menu
paradox-commit-list paradox-execute paradox-github paradox-core
magit-ediff ediff ediff-merg ediff-mult ediff-wind ediff-diff ediff-help
ediff-init ediff-util macros w3m-lnum w3m-namazu sh-script executable
dictionary link connection iso-transl bbdb-pgp view misearch
multi-isearch calc-poly calc-arith calc-misc calc-alg calc-aent metar
calc-units vc-bzr vc-src vc-sccs vc-svn vc-cvs vc-rcs request mailalias
bbdb-message dired-aux blimp eimp goto-chg undo-tree magit-extras
em-unix em-script em-prompt em-ls em-hist em-pred em-dirs esh-var
em-cmpl em-basic em-banner em-alias quail rect arc-mode archive-mode
cider-find pkg-info epl cider tramp-sh cider-debug cider-inspector
cider-browse-ns cider-repl-history pulse org-id org-crypt find-dired
display-fill-column-indicator paredit url-cache ffap qp mm-archive
w3m-cookie w3m-form w3m-symbol w3m-filter w3m-search w3m-bookmark
w3m-tabmenu w3m-session cursor-sensor sort gnus-cite mail-extr
gnus-async gnus-bcklg gnus-ml gnus-topic utf-7 bbdb-gnus gnus-delay
gnus-draft gnus-agent gnus-srvr gnus-score score-mode nnvirtual
gnus-cache gnus-msg nndraft nnmh gnus-demon nntp mule-util copyright
windmove winner jao-patches bml-logs bml bml-misc bml-whizzml
bml-clojure bml-clj-tests bml-python bml-skels bml-utils
whizzml-skeletons whizzml-mode exwm-systemtray xcb-systemtray xcb-xembed
exwm exwm-input xcb-keysyms xcb-xkb exwm-manage exwm-floating xcb-cursor
xcb-render exwm-layout exwm-workspace exwm-core xcb-ewmh xcb-icccm xcb
xcb-xproto xcb-types xcb-debug jao-lyrics jao-random-album mpdel-browser
libmpdel-directory mpdel mpdel-playlist mpdel-tablist mpdel-song
mpdel-core libmpdel time-stamp navigel circe-notifications
circe-color-nicks lui-track-bar circe-lagmon circe lui-irc-colors irc
make-tls-process tls lcs lui-format lui tracking shorten flyspell ispell
circe-compat jao-proton-utils enwc enwc-backend bluetooth jenkins
github-review gitconfig-mode conf-mode forge-list forge-commands
forge-semi forge-bitbucket buck forge-gogs gogs forge-gitea gtea
forge-gitlab glab forge-github ghub-graphql treepy gsexp ghub
forge-notify forge-revnote forge-pullreq forge-issue forge-topic
bug-reference forge-post forge-repo forge forge-core forge-db closql
emacsql-sqlite emacsql emacsql-compiler url-http url-auth url-gw
magit-bookmark magit-submodule magit-obsolete magit-blame magit-stash
magit-reflog magit-bisect magit-push magit-pull magit-fetch magit-clone
magit-remote magit-commit magit-sequence magit-notes magit-worktree
magit-tag magit-merge magit-branch magit-reset magit-files magit-refs
magit-status magit magit-repos magit-apply magit-wip magit-log
which-func magit-diff smerge-mode diff magit-core magit-autorevert
magit-margin magit-transient magit-process magit-mode git-commit
magit-git magit-section magit-utils log-edit pcvs-util add-log
with-editor async-bytecomp async git-timemachine transient diff-hl
vc-dir json-mode json-reformat json-snatcher js cc-mode cc-fonts
cc-guess cc-menus cc-cmds cc-styles cc-align cc-engine cc-vars cc-defs
merlin-company merlin-cap merlin utop utop-minor-mode tuareg speedbar
sb-image ezimage dframe smie caml-help caml-types caml-emacs find-file
erlang tempo virtualenvwrapper gud lsp-haskell haskell
haskell-completions haskell-load haskell-commands highlight-uses-mode
haskell-modules haskell-sandbox haskell-navigate-imports haskell-repl
haskell-svg haskell-collapse hideshow haskell-debug
haskell-interactive-mode haskell-presentation-mode haskell-compile
haskell-process haskell-session haskell-hoogle jao-cabal haskell-mode
haskell-cabal haskell-utils haskell-font-lock haskell-indentation
haskell-string haskell-sort-imports haskell-lexeme haskell-align-imports
haskell-compat haskell-complete-module haskell-ghc-support dabbrev
haskell-customize cider-macroexpansion cider-mode cider-completion
cider-profile cider-eval cider-repl cider-resolve cider-eldoc cider-test
cider-stacktrace cider-doc cider-browse-spec cider-clojuredocs
cider-popup cider-overlays cider-client cider-common cider-util
cider-connection sesman-browser nrepl-client tramp tramp-loaddefs
trampver tramp-integration files-x tramp-compat ls-lisp queue nrepl-dict
cider-compat parseedn parseclj-parser parseclj-lex a sesman vc
vc-dispatcher clojure-mode lisp-mnt align geiser edit-list esh-toggle
bash-completion pcmpl-pip pcmpl-args pcmpl-gnu pcmpl-linux pcmpl-unix
eshell-autojump eshell-up git-ps1-mode em-term w3m w3m-hist w3m-fb
bookmark-w3m w3m-ems w3m-favicon w3m-image tab-line w3m-proc w3m-util
term disp-table ehelp org-noter pdf-view-restore pdf-occur ibuf-ext
ibuffer ibuffer-loaddefs tablist tablist-filter semantic/wisent/comp
semantic/wisent semantic/wisent/wisent semantic/util-modes semantic/util
semantic semantic/tag semantic/lex semantic/fw mode-local cedet
pdf-isearch let-alist pdf-misc pdf-tools pdf-view bookmark pp pdf-cache
pdf-info tq pdf-util jao-doc-view counsel-bbdb bbdb-mua bbdb-anniv
bbdb-com bbdb bbdb-site timezone time jao-maildir counsel-notmuch
notmuch hl-line notmuch-hello notmuch-tree notmuch-show notmuch-print
notmuch-crypto notmuch-mua notmuch-message notmuch-draft
notmuch-maildir-fcc notmuch-address notmuch-company notmuch-parser
notmuch-wash coolj notmuch-query goto-addr notmuch-tag crm notmuch-lib
notmuch-compat smtpmail sendmail randomsig gnutls gh-md eww mm-url
url-queue ol-info ol-docview doc-view image-mode exif ol-bbdb ol-eshell
esh-mode eshell esh-cmd esh-ext esh-opt esh-proc esh-io esh-arg
esh-module esh-groups ol-w3m ol-gnus nnir gnus-icalendar org-capture
gnus-art mm-uu mml2015 mm-view mml-smime smime dig gnus-sum url
url-proxy url-privacy url-expand url-methods url-history mailcap shr
url-cookie url-domsuf svg dom gnus-group gnus-undo gnus-start gnus-cloud
nnimap nnmail mail-source utf7 netrc nnoo parse-time iso8601 gnus-spec
gnus-int gnus-range message rfc822 mml mml-sec mailabbrev mailheader
gnus-win mm-decode mm-bodies mm-encode mail-parse rfc2231 gmm-utils
icalendar org-agenda gnus nnheader gnus-util rmail rmail-loaddefs
rfc2047 rfc2045 ietf-drums text-property-search mail-utils mm-util
mail-prsvr jao-org-links jao-devon jao-applescript jao-org-utils
org-protocol ob-shell shell ob-scheme ob-python ob-org ob-ocaml
ob-makefile ob-haskell ob-gnuplot ob-clojure ob-calc calc-store
calc-trail calc-ext calc calc-loaddefs calc-macs ox-odt rng-loc rng-uri
rng-parse rng-match rng-dt rng-util rng-pttrn nxml-parse nxml-ns
nxml-enc xmltok nxml-util ox-latex ox-icalendar ox-html table ox-ascii
ox-publish ox org-element avl-tree org ob ob-tangle ob-ref ob-lob
ob-table ob-exp org-macro org-footnote org-src ob-comint org-pcomplete
pcomplete org-list org-faces org-entities time-date org-version
ob-emacs-lisp ob-core ob-eval org-table ol org-keys org-compat org-macs
org-loaddefs format-spec jao-frm jao-notify cus-edit cus-start cus-load
paren which-key helpful trace edebug backtrace info-look advice
find-func help-fns radix-tree elisp-refs loop jao-dark-forest-theme
jao-themes persistent-soft list-utils pcache eieio-base font-utils
unicode-fonts dired-x autorevert jka-compr company-oddmuse
company-keywords company-etags etags fileloop generator company-gtags
company-dabbrev-code company-dabbrev company-files company-capf
company-cmake company-xcode company-clang company-semantic company-eclim
company-template company-bbdb persistent-scratch epa-file epa derived
epg epg-config symon battery cal-china lunar solar cal-dst cal-bahai
cal-islam cal-hebrew holidays hol-loaddefs vc-git diff-mode appt
diary-lib diary-loaddefs cal-menu calendar cal-loaddefs company-math
math-symbol-lists company lsp-ivy lsp-mode ewoc markdown-mode noutline
outline url-util spinner pcase network-stream puny nsm rmc inline imenu
ht filenotify f s em-glob esh-util dash-functional bindat flymake-proc
flymake warnings thingatpt dash alert log4e notifications dbus xml gntp
ivy-rich counsel-jq wgrep-ag wgrep grep ivy-hydra hydra lv counsel xdg
xref project dired dired-loaddefs compile comint ansi-color swiper ivy
flx delsel ring colir color ivy-overlay edmacro kmacro texinfo-skel
lisp-skel muse-skel haskell-skel jao-dominating-file scsh-skel init-skel
common-skel skeleton autoinsert diminish server savehist recentf
tree-widget wid-edit saveplace gnu-elpa-keyring-update cl-extra
help-mode use-package use-package-ensure use-package-delight
use-package-diminish use-package-bind-key bind-key easy-mmode
use-package-core finder-inf tex-site gh-common marshal eieio-compat rx
cl w3m-load info package easymenu browse-url url-handlers url-parse
auth-source cl-seq eieio eieio-core cl-macs eieio-loaddefs
password-cache json subr-x map url-vars seq byte-opt gv bytecomp
byte-compile cconv cl-loaddefs cl-lib tooltip eldoc electric uniquify
ediff-hook vc-hooks lisp-float-type mwheel term/x-win x-win
term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe
tabulated-list replace newcomment text-mode elisp-mode lisp-mode
prog-mode register page tab-bar menu-bar rfn-eshadow isearch timer
select scroll-bar mouse jit-lock font-lock syntax facemenu font-core
term/tty-colors frame minibuffer cl-generic cham georgian utf-8-lang
misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms
cp51932 hebrew greek romanian slovak czech european ethiopic indian
cyrillic chinese composite charscript charprop case-table epa-hook
jka-cmpr-hook help simple abbrev obarray cl-preloaded nadvice loaddefs
button faces cus-face macroexp files text-properties overlay sha1 md5
base64 format env code-pages mule custom widget hashtable-print-readable
backquote threads dbusbind inotify lcms2 dynamic-setting
system-font-setting font-render-setting x multi-tty make-network-process
emacs)

Memory information:
((conses 16 7294478 878009)
 (symbols 48 88755 141)
 (strings 32 1028806 165004)
 (string-bytes 1 33225058)
 (vectors 16 322688)
 (vector-slots 8 6779410 723388)
 (floats 8 19073 13917)
 (intervals 56 579930 90117)
 (buffers 1000 655))

-- 
Tact is the ability to tell a man he has an open mind when he has a
hole in his head.