bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#23412: 25.1.50; GUI Emacs on Mac OS X: text is keeping shaking/re-di


From: tsuucat
Subject: bug#23412: 25.1.50; GUI Emacs on Mac OS X: text is keeping shaking/re-displaying when insert text with external input method
Date: Thu, 19 Dec 2019 09:31:29 +0900

> Can I ask what this change does?
> 
> -    (overlay-put (setq ns-working-overlay (make-overlay start (point)
> -                                                     (current-buffer) nil t))
> +    (overlay-put (setq ns-working-overlay (make-overlay start (point)))


At first I thought it would be fixed just by moving [self deleteWorkingText] in 
nsterm.m.
However as a result insertText (ex: pressing RET to input selected candidates) 
left nothing.

That’s because ns-delete-working-text (by  [self deleteWorkingText]) delete all 
inserted 
chars including chars inserted by insertText-emited normal input events. This 
patch prevent 
ns-working-overlay expanding its size in insertText.


Unfortunately I found the patch change behavior of undo worse. So NS-spesific 
patch should 
have further modification.

--
tsuucat






reply via email to

[Prev in Thread] Current Thread [Next in Thread]