bug#34343: [PATCH] Make project--find-regexp-in-files work with remote files

[Michael Albinus]

Dmitry Gutov <dgutov@yandex.ru> writes:

Hi Dmitry,

>> The patch looks reasonable to me. Since I don't use project-files, I
>> can't say whether this works correctly.
>
> Unless it's a religious position, you can test it with:
>
>   M-x project-find-regexp
>
> or
>
>   M-x dired-do-find-regexp (also bound to 'A' in Dired)
>
> (the latter since one of my yesterday's commits).

No religious barrier here :-)

> For now, I've done some testing myself. It prepended 'remote-id'
> twice, now fixed.

I've tested with the emacs-27 branch, and it seems to work.

> Things I've noticed:
>
> - (mapcar #'file-local-name files) takes like ~2 seconds when FILES
>   only has ~3000 elements. The same code completes instantly on a
>  local machine. Shouldn't it be the same?

file-local-name uses internally file-remote-p, which calls
expand-file-name if the connection is already established. Not needed in
case of local names.

Could you pls test the appended patch, whether it improves performance?

Best regards, Michael.

txtpgsvOhQ9Sz.txt
Description: Text document