[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#39452: [PATCH] vc-git-state fails for filenames with wildcards
From: |
Eli Zaretskii |
Subject: |
bug#39452: [PATCH] vc-git-state fails for filenames with wildcards |
Date: |
Fri, 07 Feb 2020 11:26:54 +0200 |
> Cc: 39452@debbugs.gnu.org, Wolfgang.Scherer@gmx.de
> From: Dmitry Gutov <dgutov@yandex.ru>
> Date: Fri, 7 Feb 2020 11:43:36 +0300
>
> On 07.02.2020 10:57, Eli Zaretskii wrote:
> >> From: Dmitry Gutov <dgutov@yandex.ru>
> >> Date: Fri, 7 Feb 2020 02:00:38 +0300
> >>
> >> I wonder how many other backends commands are broken for files like
> >> that: we basically never shell-quote file names.
> >
> > Whenever we run commands via the shell, the prudent thing is to always
> > quote file names (and in general any argument that might include
> > wildcard characters). One advantage of call-process is that you don't
> > have to do that.
>
> It's not so simple. FILE already goes through call-process. But Git
> expects a pathspec, not just a file name. So if it's a glob, it is expanded.
What I wrote was a response to your "we basically never quote". Let
me correct my perhaps too-general response by saying "the prudent
thing is to always quote file names, unless the command expects a
wildcard in that argument".
- bug#39452: [PATCH] vc-git-state fails for filenames with wildcards, Wolfgang Scherer, 2020/02/06
- bug#39452: [PATCH] vc-git-state fails for filenames with wildcards, Dmitry Gutov, 2020/02/06
- bug#39452: [PATCH] vc-git-state fails for filenames with wildcards, Eli Zaretskii, 2020/02/07
- bug#39452: [PATCH] vc-git-state fails for filenames with wildcards, Noam Postavsky, 2020/02/07
- bug#39452: [PATCH] vc-git-state fails for filenames with wildcards, Dmitry Gutov, 2020/02/11
- bug#39452: [PATCH] vc-git-state fails for filenames with wildcards, Noam Postavsky, 2020/02/12
- bug#39452: [PATCH] vc-git-state fails for filenames with wildcards, Wolfgang Scherer, 2020/02/13
- bug#39452: [PATCH] vc-git-state fails for filenames with wildcards, Dmitry Gutov, 2020/02/13
- bug#39452: [PATCH] vc-git-state fails for filenames with wildcards, Eli Zaretskii, 2020/02/14
- bug#39452: [PATCH] vc-git-state fails for filenames with wildcards, Dmitry Gutov, 2020/02/14
- bug#39452: [PATCH] vc-git-state fails for filenames with wildcards, Eli Zaretskii, 2020/02/14
- bug#39452: [PATCH] vc-git-state fails for filenames with wildcards, Dmitry Gutov, 2020/02/14