[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#39555: [PATCH] Allow tempo-define-template to reassign tags to new t
|
From: |
Federico Tedin |
|
Subject: |
bug#39555: [PATCH] Allow tempo-define-template to reassign tags to new templates |
|
Date: |
Mon, 17 Feb 2020 22:27:51 +0100 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.3 (darwin) |
> I think this should go to master in any case.
>
> Given that tempo.el is not actively maintained lately, I think you can
> install your changes, after taking care of the minor issues below.
>
>> -(defun tempo-invalidate-collection ()
>> +(defun tempo-invalidate-collection (&optional global)
>> "Marks the tag collection as obsolete.
>> -Whenever it is needed again it will be rebuilt."
>> - (setq tempo-dirty-collection t))
>> +Whenever it is needed again it will be rebuilt. When GLOBAL is
> ^^^^
> Please use "if", not "when". That's our usual style of describing
> optional arguments.
>
> I think the API changes should be in NEWS.
>
> Thanks.
No problem, I'm attaching a new patch with those corrections applied.
- Fede
0001-Allow-tempo-define-template-to-reassign-tags-to-new-.patch
Description: Text Data