[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#39596: 26.3; Export INSIDE_EMACS with Eshell
From: |
Federico Tedin |
Subject: |
bug#39596: 26.3; Export INSIDE_EMACS with Eshell |
Date: |
Wed, 19 Feb 2020 22:16:05 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) |
Andreas Schwab <schwab@suse.de> writes:
> On Feb 19 2020, Federico Tedin wrote:
>
>> Pierre Neidhardt <mail@ambrevar.xyz> writes:
>>
>>> Thanks for looking at this, Federico!
>>>
>>> Your patch looks good to me, just one comment below:
>>>
>>>> --- a/lisp/eshell/em-dirs.el
>>>> +++ b/lisp/eshell/em-dirs.el
>>>> @@ -191,6 +191,9 @@ eshell-dirs-initialize
>>>> (unless (ring-empty-p eshell-last-dir-ring)
>>>> (expand-file-name
>>>> (ring-ref eshell-last-dir-ring 0))))
>>>> + t)
>>>> + ("INSIDE_EMACS" ,(lambda (_indices)
>>>> + (format "%s,eshell" emacs-version))
>>>> t))))
>>>
>>> Why did you unquote the lambda here?
>>
>> I need to unquote the lambda to get its value, right?
>
> Unquoting allows it to be byte-compiled.
>
> Andreas.
Wasn't aware of that, thanks.