[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#39980: [PATCH] gnus-shorten-url: Improve and avoid args-out-of-range
|
From: |
Lars Ingebrigtsen |
|
Subject: |
bug#39980: [PATCH] gnus-shorten-url: Improve and avoid args-out-of-range error |
|
Date: |
Sat, 14 Mar 2020 12:41:34 +0100 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) |
Štěpán Němec <stepnem@gmail.com> writes:
> 'gnus-shorten-url' (used by 'gnus-summary-browse-url') ignored
> fragment identifiers and didn't check substring bounds, in some cases
> leading to runtime errors, e.g.:
>
> (gnus-shorten-url "https://some.url.with/path/and#also_a_long_target"; 40)
> ;; => Lisp error: (args-out-of-range "/path/and" -18 nil)
>
> This commit makes it account for #fragments and fixes faulty string
> computation, reusing existing helper function.
Looks like a good fix to me, but is there a reason this is a defsubst
instead of a defun?
+(defsubst string-truncate-left (string length)
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no