bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#40119: [PATCH] Make compilation-mode regexp matching case-sensitive


From: Eli Zaretskii
Subject: bug#40119: [PATCH] Make compilation-mode regexp matching case-sensitive
Date: Wed, 18 Mar 2020 20:05:07 +0200

> From: Mattias Engdegård <mattiase@acm.org>
> Date: Wed, 18 Mar 2020 16:31:49 +0100
> 
> +** Compilation mode
> +
> +*** Regexp matching of messages is now case-sensitive.
> +
>  
>  * New Modes and Packages in Emacs 28.1
>  
> diff --git a/lisp/progmodes/compile.el b/lisp/progmodes/compile.el
> index 455f181f50..aefaa1707a 100644
> --- a/lisp/progmodes/compile.el
> +++ b/lisp/progmodes/compile.el
> @@ -1435,7 +1435,8 @@ compilation-parse-errors
>      (if (symbolp item)
>          (setq item (cdr (assq item
>                                compilation-error-regexp-alist-alist))))
> -    (let ((file (nth 1 item))
> +    (let ((case-fold-search nil)
> +          (file (nth 1 item))
>            (line (nth 2 item))
>            (col (nth 3 item))
>            (type (nth 4 item))

What if we are wrong and some compiler needs case-insensitive
matching?  Your change makes it impossible to get back the old
behavior, not even optionally.

Thanks.





reply via email to

[Prev in Thread] Current Thread [Next in Thread]