[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#40407: [PATCH] slow ENCODE_FILE and DECODE_FILE
From: |
OGAWA Hirofumi |
Subject: |
bug#40407: [PATCH] slow ENCODE_FILE and DECODE_FILE |
Date: |
Mon, 06 Apr 2020 19:10:48 +0900 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) |
Eli Zaretskii <eliz@gnu.org> writes:
>> - if (BUFFERP (dst_object))
>> + if (EQ (dst_object, Qt))
>> + {
>> + /* Fast path for ASCII-only input and an ASCII-compatible coding:
>> + act as identity. */
>> + Lisp_Object attrs = CODING_ID_ATTRS (coding.id);
>> + if (! NILP (CODING_ATTR_ASCII_COMPAT (attrs))
>> + && (STRING_MULTIBYTE (string)
>> + ? (chars == bytes) : string_ascii_p (string)))
>> + return string;
While using the latest master branch, I noticed this became the cause of
decoding error.
The simple reproducible test is,
(decode-coding-string "&abc" 'utf-7-imap)
=> "&abc"
like the above result, decoding utf-7-imap didn't work.
Because (coding-system-get 'utf-7-imap :ascii-compatible-p) => t.
I'm not sure, 'utf-7* should be fixed as non ascii-compatible, or
string_ascii_p() should check more strictly.
[BTW,
(define-coding-system 'utf-7-imap
"UTF-7 encoding of Unicode, IMAP version (RFC 2060)"
:coding-type 'utf-8
:mnemonic ?u
:charset-list '(unicode)
:ascii-compatible-p nil ;; <=== added this line
:pre-write-conversion 'utf-7-imap-pre-write-conversion
:post-read-conversion 'utf-7-imap-post-read-conversion)
doesn't work. Because define-coding-system-internal overwrites
ascii-compatible-p.]
Thanks.
--
OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
- bug#40407: [PATCH] slow ENCODE_FILE and DECODE_FILE, (continued)
- bug#40407: [PATCH] slow ENCODE_FILE and DECODE_FILE, Eli Zaretskii, 2020/04/04
- bug#40407: [PATCH] slow ENCODE_FILE and DECODE_FILE, Mattias Engdegård, 2020/04/04
- bug#40407: [PATCH] slow ENCODE_FILE and DECODE_FILE, Eli Zaretskii, 2020/04/04
- bug#40407: [PATCH] slow ENCODE_FILE and DECODE_FILE, Mattias Engdegård, 2020/04/05
- bug#40407: [PATCH] slow ENCODE_FILE and DECODE_FILE, Eli Zaretskii, 2020/04/05
- bug#40407: [PATCH] slow ENCODE_FILE and DECODE_FILE, Mattias Engdegård, 2020/04/05
- bug#40407: [PATCH] slow ENCODE_FILE and DECODE_FILE, Mattias Engdegård, 2020/04/05
- bug#40407: [PATCH] slow ENCODE_FILE and DECODE_FILE, Eli Zaretskii, 2020/04/05
- bug#40407: [PATCH] slow ENCODE_FILE and DECODE_FILE, Mattias Engdegård, 2020/04/06
- bug#40407: [PATCH] slow ENCODE_FILE and DECODE_FILE, Eli Zaretskii, 2020/04/05
bug#40407: [PATCH] slow ENCODE_FILE and DECODE_FILE,
OGAWA Hirofumi <=
- bug#40407: [PATCH] slow ENCODE_FILE and DECODE_FILE, Eli Zaretskii, 2020/04/06
- bug#40407: [PATCH] slow ENCODE_FILE and DECODE_FILE, Mattias Engdegård, 2020/04/06
- bug#40407: [PATCH] slow ENCODE_FILE and DECODE_FILE, Eli Zaretskii, 2020/04/06
- bug#40407: [PATCH] slow ENCODE_FILE and DECODE_FILE, Mattias Engdegård, 2020/04/06
- bug#40407: [PATCH] slow ENCODE_FILE and DECODE_FILE, Eli Zaretskii, 2020/04/06
- bug#40407: [PATCH] slow ENCODE_FILE and DECODE_FILE, Mattias Engdegård, 2020/04/06
- bug#40407: [PATCH] slow ENCODE_FILE and DECODE_FILE, Eli Zaretskii, 2020/04/06
- bug#40407: [PATCH] slow ENCODE_FILE and DECODE_FILE, OGAWA Hirofumi, 2020/04/06
- bug#40407: [PATCH] slow ENCODE_FILE and DECODE_FILE, Mattias Engdegård, 2020/04/06
- bug#40407: [PATCH] slow ENCODE_FILE and DECODE_FILE, Mattias Engdegård, 2020/04/09