[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#39980: [PATCH] gnus-shorten-url: Improve and avoid args-out-of-range
From: |
Štěpán Němec |
Subject: |
bug#39980: [PATCH] gnus-shorten-url: Improve and avoid args-out-of-range error |
Date: |
Sun, 12 Apr 2020 16:13:23 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) |
On Sun, 12 Apr 2020 16:38:57 +0300
Eli Zaretskii wrote:
>> You mean instead of reusing an existing function, fix `gnus-shorten-url'
>> without using it?
>
> Almost: the "existing function" doesn't really exist, you introduced
> it with the same changeset, right?
No, it's the (hopefully) tried and true `ediff-truncate-string-left',
only renamed and moved to subr-x to be generally available. The changes
are cosmetic. It would even be possible (in emacs-27, to avoid moving
anything), to use `ediff-truncate-string-left' unchanged, but that would
require gnus-sum to (require 'ediff-init), which would be crazy. Or make
`ediff-truncate-string-left' a defsubst instead of defun and
(eval-when-compile (require 'ediff-init)) in gnus-sum. That should
actually work :-P
> Both variants of the log message are fine.
Thanks.
--
Štěpán
- bug#39980: [PATCH] gnus-shorten-url: Improve and avoid args-out-of-range error, Lars Ingebrigtsen, 2020/04/02
- bug#39980: [PATCH] gnus-shorten-url: Improve and avoid args-out-of-range error, Štěpán Němec, 2020/04/12
- bug#39980: [PATCH] gnus-shorten-url: Improve and avoid args-out-of-range error, Eli Zaretskii, 2020/04/12
- bug#39980: [PATCH] gnus-shorten-url: Improve and avoid args-out-of-range error, Štěpán Němec, 2020/04/12
- bug#39980: [PATCH] gnus-shorten-url: Improve and avoid args-out-of-range error, Eli Zaretskii, 2020/04/12
- bug#39980: [PATCH] gnus-shorten-url: Improve and avoid args-out-of-range error, Štěpán Němec, 2020/04/12
- bug#39980: [PATCH] gnus-shorten-url: Improve and avoid args-out-of-range error, Eli Zaretskii, 2020/04/12
- bug#39980: [PATCH] gnus-shorten-url: Improve and avoid args-out-of-range error,
Štěpán Němec <=
- bug#39980: [PATCH] gnus-shorten-url: Improve and avoid args-out-of-range error, Eli Zaretskii, 2020/04/12
- bug#39980: [PATCH] gnus-shorten-url: Improve and avoid args-out-of-range error, Štěpán Němec, 2020/04/12
- bug#39980: [PATCH] gnus-shorten-url: Improve and avoid args-out-of-range error, Eli Zaretskii, 2020/04/13
- bug#39980: [PATCH] gnus-shorten-url: Improve and avoid args-out-of-range error, Štěpán Němec, 2020/04/13