bug#35546: 27.0.50; setf return value for new alist entries is wrong

[Michael Heerdegen]

Štěpán Němec <stepnem@gmail.com> writes:

> >>                   (lambda (v)
> >> +                   (macroexp-let2 nil v v
> >
> > Binding v to the value of v seems needlessly confusing.  How about
> > renaming the lambda parameter to valexp or somthing like that?
>
> I kind of agree, although really, I wish that would be the most
> confusing part about gv.el. :-]
>
> I did it like that because 1. this practice seems pretty common in Emacs
> sources already, 2. it makes for the minimal change here.

It's a matter of taste.  I read it like that `macroexp-let2' arranges
that the expression v refers to is evaluated only once, but not anything
else (if used correctly), so keeping the name is not more confusing than
torturing the reader with one more variable to remember in that already
not so easy to read code.

Apart from that debatable point the change looks reasonable to me.


Thanks,

Michael.