[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#40562: [patch] Treat records as arrays in ert object comparisons and
|
From: |
Clément Pit-Claudel |
|
Subject: |
bug#40562: [patch] Treat records as arrays in ert object comparisons and add support for cl-structs |
|
Date: |
Sat, 25 Apr 2020 17:27:53 -0400 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 |
On 12/04/2020 11.50, Clément Pit-Claudel wrote:
> On 12/04/2020 05.24, Štěpán Němec wrote:
>> On Sat, 11 Apr 2020 23:06:47 -0400
>> Clément Pit-Claudel wrote:
>>
>>> On 11/04/2020 19.26, Štěpán Němec wrote:
>>>> This is incorrect, as witnessed by your very example (`c' instead of
>>>> `b'). Records are accessible with `aref', but the first slot is the type
>>>> descriptor, so you're making an off-by-one error here.
>>>
>>> Of course, it should be `for slot in (cl-struct-slot-info (type-of
>>> a))` not `for slot in (cdr (cl-struct-slot-info (type-of a)))`.
>>> Updated patch attached.
>>
>> Hm, except now you're duplicating the (eq (type-of a) (type-of b))
>> check.
>
> Yup; I don't think that's a problem :)
Is there anything else I should do before pushing this patch?