[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#40532: 28.0.50; eww/shr: Anchor link does not work
From: |
Basil L. Contovounesios |
Subject: |
bug#40532: 28.0.50; eww/shr: Anchor link does not work |
Date: |
Thu, 30 Apr 2020 11:15:32 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) |
Lars Ingebrigtsen <larsi@gnus.org> writes:
> Eli Zaretskii <eliz@gnu.org> writes:
>
>> I think this is OK for the release branch, but I'd like Lars to
>> comment. Lars, please chime in.
>
> I think this looks correct:
>
> - (let ((dom (plist-get eww-data :dom)))
> + (let ((dom (plist-get eww-data :dom))
> + (shr-target-id (url-target (url-generic-parse-url url))))
>
> But I haven't tested the code.
Why not move this binding back into eww-display-html instead, closer to
where shr-insert-document is called, for the benefit of other callers of
eww-display-html as well, and deviating the least from previous versions
of eww, as per the second proposed patch?
Thanks,
--
Basil
- bug#40532: 28.0.50; eww/shr: Anchor link does not work, (continued)
- bug#40532: 28.0.50; eww/shr: Anchor link does not work, Eli Zaretskii, 2020/04/22
- bug#40532: 28.0.50; eww/shr: Anchor link does not work, Basil L. Contovounesios, 2020/04/22
- bug#40532: 28.0.50; eww/shr: Anchor link does not work, Eli Zaretskii, 2020/04/22
- bug#40532: 28.0.50; eww/shr: Anchor link does not work, Basil L. Contovounesios, 2020/04/22
- bug#40532: 28.0.50; eww/shr: Anchor link does not work, Eli Zaretskii, 2020/04/22
- bug#40532: 28.0.50; eww/shr: Anchor link does not work, Basil L. Contovounesios, 2020/04/22
- bug#40532: 28.0.50; eww/shr: Anchor link does not work, Arnaud Fontaine, 2020/04/22
- bug#40532: 28.0.50; eww/shr: Anchor link does not work, Basil L. Contovounesios, 2020/04/22
- bug#40532: 28.0.50; eww/shr: Anchor link does not work, Eli Zaretskii, 2020/04/25
- bug#40532: 28.0.50; eww/shr: Anchor link does not work, Lars Ingebrigtsen, 2020/04/30
- bug#40532: 28.0.50; eww/shr: Anchor link does not work,
Basil L. Contovounesios <=
- bug#40532: 28.0.50; eww/shr: Anchor link does not work, Lars Ingebrigtsen, 2020/04/30