bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#40727: 27.0.91; 'cl-loop ... across ... and' seems broken


From: Noam Postavsky
Subject: bug#40727: 27.0.91; 'cl-loop ... across ... and' seems broken
Date: Thu, 30 Apr 2020 19:40:43 -0400
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.91 (gnu/linux)

Noam Postavsky <npostavs@gmail.com> writes:

> By the way, while adding the test case I found an additional regression
> involving loop termination by a 'var = ...' clause.  I'll open another
> bug about it soon.

Actually, it's very closely connected (only observable after fixing the
original bug, since otherwise the necessary conditions trigger the
--cl-vec-- is void error), so I'll keep it here.  When there is a
(cl-loop for VAR across ARRAY and VAR2 = ...) the array index would get
incremented twice per loop.  Fixed by the patch below (applies on top of
the patch in my previous message).

Attachment: 0002-Don-t-increment-array-index-in-cl-loop-twice-Bug-407.patch
Description: patch

Eli, is it okay to push both of these to emacs-27?  Alternatively,
reverting both fixes to Bug#29799 in addition to the Bug#29866 fix
works:

Attachment: 0001-Revert-Refix-conditional-step-clauses-in-cl-loop.patch
Description: patch

Attachment: 0002-Revert-cl-loop-Add-missing-guard-condition.patch
Description: patch

Attachment: 0003-Revert-cl-loop-Calculate-the-array-length-just-once.patch
Description: patch

Attachment: 0004-Mark-Bug-29799-tests-as-failing-since-we-reverted-th.patch
Description: patch


reply via email to

[Prev in Thread] Current Thread [Next in Thread]