|
From: | Stefan Kangas |
Subject: | bug#40863: [PATCH] Improve the display-time-world UI |
Date: | Sat, 02 May 2020 18:10:19 +0200 |
User-agent: | Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) |
"Basil L. Contovounesios" <contovob@tcd.ie> writes: > Stefan Kangas <stefan@marxist.se> writes: > >> I have made some improvements to the display-time-world UI. I divided >> them up into four patches to ease review and merging of the individual >> features. Please let me know what you think. > > Thanks for working on this, see my comments below. > >> (Of course I can squash the patches before pushing if that is preferable.) >> >> Patch 4 adds an alias 'world-clock'. Ideally, I would like to rename >> the somewhat obscurely named 'display-world-time' to 'world-clock' and >> make the old names into obsolete aliases. It would be good to hear >> any opinions on that too. > > No strong feelings either way here. So here's a revised set of patches: 1. Fix all Basil's comments, and remove the buffer rename that Eli didn't approve of. 2. Rename 'display-time-world' to 'world-clock', and add an alias for the old name. Then comes the more ambitious part: 3. Rename 'display-time-world-*' functions and variables into 'world-clock-*' equivalents and make the old names into obsolete aliases. Move the world-clock options from the defgroup display-time (sorting under the mode-line and mail), into a new defgroup world-clock (sorting under applications). 4. Rearrange the defcustoms time.el to clearly separate world-clock from display-time-mode. Cleanup of :group args. I have seen no to the proposals in patches 1-2 so far, and I hope that we can agree to make the changes also in patches 3-4. I think the result is much more logical from pretty much any point of view. Comments are obviously very welcome. Best regards, Stefan Kangas
0001-Improve-display-time-world-UI-Bug-40863.patch
Description: Text Data
0002-Make-display-time-world-into-an-alias-for-world-cloc.patch
Description: Text Data
0003-Rename-display-time-world-to-world-clock-Bug-40863.patch
Description: Text Data
0004-Rearrange-and-cleanup-code-in-time.el-Bug-40863.patch
Description: Text Data
[Prev in Thread] | Current Thread | [Next in Thread] |