[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#29533: Fwd: [Feature Request] ERC: let erc-join-channel support to s
From: |
Noam Postavsky |
Subject: |
bug#29533: Fwd: [Feature Request] ERC: let erc-join-channel support to select channels from history or a defined list |
Date: |
Wed, 13 May 2020 10:29:31 -0400 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.3 (windows-nt) |
stardiviner <numbchild@gmail.com> writes:
> ;;; original code
> (defun erc-join-channel (channel &optional key)
> "Join CHANNEL.
>
> If `point' is at the beginning of a channel name, use that as default."
> (interactive
> (list [...]
> (defun erc-join-channel-select (args)
> "Select a channel to join from alist of channels to."
> (let ((channel (completing-read
> "Select a channel: "
> (cdr (assoc
> (completing-read "Select a server: "
> (mapcar 'car
> erc-join-channels-alist))
> erc-join-channels-alist)))))
> (setq args (list channel))))
> (advice-add 'erc-join-channel :filter-args 'erc-join-channel-select)
> When I press [C-c C-j] (erc-join-channel), the advice is added on function,
> but seems not working. Don't know why, do you have any clue?
I think advice doesn't affect interactive calls the way you expect. I
forget the details of it, but anyway it's probably better to just remap
instead, along the lines of:
(defun erc-join-channel-select ()
"Select a channel to join from alist of channels to."
(erj-join-channel
(completing-read
"Select a channel: "
(cdr (assoc
(completing-read "Select a server: "
(mapcar 'car erc-join-channels-alist))
erc-join-channels-alist)))))
(define-key erc-mode-map [remap erc-join-channel] 'erc-join-channel-select)
- bug#29533: Fwd: [Feature Request] ERC: let erc-join-channel support to select channels from history or a defined list, (continued)
- bug#29533: Fwd: [Feature Request] ERC: let erc-join-channel support to select channels from history or a defined list, Stefan Kangas, 2020/05/04
- bug#29533: Fwd: [Feature Request] ERC: let erc-join-channel support to select channels from history or a defined list, stardiviner, 2020/05/12
- bug#29533: Fwd: [Feature Request] ERC: let erc-join-channel support to select channels from history or a defined list, Stefan Kangas, 2020/05/12
- bug#29533: Fwd: [Feature Request] ERC: let erc-join-channel support to select channels from history or a defined list, stardiviner, 2020/05/13
- bug#29533: Fwd: [Feature Request] ERC: let erc-join-channel support to select channels from history or a defined list, stardiviner, 2020/05/13
- bug#29533: Fwd: [Feature Request] ERC: let erc-join-channel support to select channels from history or a defined list, Stefan Kangas, 2020/05/13
- bug#29533: Fwd: [Feature Request] ERC: let erc-join-channel support to select channels from history or a defined list, stardiviner, 2020/05/13
- bug#29533: Fwd: [Feature Request] ERC: let erc-join-channel support to select channels from history or a defined list, Stefan Kangas, 2020/05/14
- bug#29533: Fwd: [Feature Request] ERC: let erc-join-channel support to select channels from history or a defined list, stardiviner, 2020/05/18
- bug#29533: Fwd: [Feature Request] ERC: let erc-join-channel support to select channels from history or a defined list, Stefan Kangas, 2020/05/18
- bug#29533: Fwd: [Feature Request] ERC: let erc-join-channel support to select channels from history or a defined list,
Noam Postavsky <=
- bug#29533: Fwd: [Feature Request] ERC: let erc-join-channel support to select channels from history or a defined list, stardiviner, 2020/05/13