[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#41276: [PATCH 7/9] Cosmetic changes to epa libraries
From: |
Jonas Bernoulli |
Subject: |
bug#41276: [PATCH 7/9] Cosmetic changes to epa libraries |
Date: |
Thu, 14 May 2020 22:16:16 +0200 |
* lisp/epa-dired.el (epa-dired-do-decrypt, epa-dired-do-verify
epa-dired-do-sign, epa-dired-do-encrypt): Use dolist instead of while.
* lisp/epa-file.el (epa-file-passphrase-callback-function): Set just
one variable per setq call.
---
lisp/epa-dired.el | 44 ++++++++++++++++++--------------------------
lisp/epa-file.el | 4 ++--
2 files changed, 20 insertions(+), 28 deletions(-)
diff --git a/lisp/epa-dired.el b/lisp/epa-dired.el
index 1bcfb758ed..4ff1ba3394 100644
--- a/lisp/epa-dired.el
+++ b/lisp/epa-dired.el
@@ -30,48 +30,40 @@
(defun epa-dired-do-decrypt ()
"Decrypt marked files."
(interactive)
- (let ((file-list (dired-get-marked-files)))
- (while file-list
- (epa-decrypt-file (expand-file-name (car file-list)))
- (setq file-list (cdr file-list)))
- (revert-buffer)))
+ (dolist (file (dired-get-marked-files))
+ (epa-decrypt-file (expand-file-name file)))
+ (revert-buffer))
;;;###autoload
(defun epa-dired-do-verify ()
"Verify marked files."
(interactive)
- (let ((file-list (dired-get-marked-files)))
- (while file-list
- (epa-verify-file (expand-file-name (car file-list)))
- (setq file-list (cdr file-list)))))
+ (dolist (file (dired-get-marked-files))
+ (epa-verify-file (expand-file-name file))))
;;;###autoload
(defun epa-dired-do-sign ()
"Sign marked files."
(interactive)
- (let ((file-list (dired-get-marked-files)))
- (while file-list
- (epa-sign-file
- (expand-file-name (car file-list))
- (epa-select-keys (epg-make-context) "Select keys for signing.
+ (dolist (file (dired-get-marked-files))
+ (epa-sign-file
+ (expand-file-name file)
+ (epa-select-keys (epg-make-context) "Select keys for signing.
If no one is selected, default secret key is used. "
- nil t)
- (y-or-n-p "Make a detached signature? "))
- (setq file-list (cdr file-list)))
- (revert-buffer)))
+ nil t)
+ (y-or-n-p "Make a detached signature? ")))
+ (revert-buffer))
;;;###autoload
(defun epa-dired-do-encrypt ()
"Encrypt marked files."
(interactive)
- (let ((file-list (dired-get-marked-files)))
- (while file-list
- (epa-encrypt-file
- (expand-file-name (car file-list))
- (epa-select-keys (epg-make-context) "Select recipients for encryption.
-If no one is selected, symmetric encryption will be performed. "))
- (setq file-list (cdr file-list)))
- (revert-buffer)))
+ (dolist (file (dired-get-marked-files))
+ (epa-encrypt-file
+ (expand-file-name file)
+ (epa-select-keys (epg-make-context) "Select recipients for encryption.
+If no one is selected, symmetric encryption will be performed. ")))
+ (revert-buffer))
(provide 'epa-dired)
diff --git a/lisp/epa-file.el b/lisp/epa-file.el
index 3e23c09a51..de51c59c34 100644
--- a/lisp/epa-file.el
+++ b/lisp/epa-file.el
@@ -66,8 +66,8 @@ epa-file-passphrase-callback-function
(or (copy-sequence (cdr entry))
(progn
(unless entry
- (setq entry (list file)
- epa-file-passphrase-alist
+ (setq entry (list file))
+ (setq epa-file-passphrase-alist
(cons entry
epa-file-passphrase-alist)))
(setq passphrase (epa-passphrase-callback-function context
--
2.26.0
- bug#41276: Acknowledgement ([PATCH 0/9] Various small improvements to EasyPG), (continued)
bug#41276: [PATCH 1/9] * lisp/epa.el (epa-faces): Move definition, Jonas Bernoulli, 2020/05/14
- bug#41276: [PATCH 2/9] Add all epa faces to epa-faces Custom group, Jonas Bernoulli, 2020/05/14
- bug#41276: [PATCH 6/9] Drop unnecessary backward compatibility aliases, Jonas Bernoulli, 2020/05/14
- bug#41276: [PATCH 3/9] * lisp/epg-config.el (epg-config--make-gpg-configuration): Fix indentation, Jonas Bernoulli, 2020/05/14
- bug#41276: [PATCH 8/9] epa-key-list-mode-map: Use widget-keymap as parent keymap, Jonas Bernoulli, 2020/05/14
- bug#41276: [PATCH 5/9] Improve and add doc-strings, Jonas Bernoulli, 2020/05/14
- bug#41276: [PATCH 7/9] Cosmetic changes to epa libraries,
Jonas Bernoulli <=
- bug#41276: [PATCH 9/9] * lisp/epa.el (epa-show-key): New command, Jonas Bernoulli, 2020/05/14
- bug#41276: [PATCH 4/9] Split EasyPG libraries into outline sections, Jonas Bernoulli, 2020/05/14
bug#41276: [PATCH 0/9] Various small improvements to EasyPG, Stefan Kangas, 2020/05/14