[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#41198: 27.0.60; [PATCH] heading cycling command for outline
From: |
Yuan Fu |
Subject: |
bug#41198: 27.0.60; [PATCH] heading cycling command for outline |
Date: |
Tue, 19 May 2020 14:31:52 -0400 |
> On May 18, 2020, at 10:45 PM, Stefan Kangas <stefan@marxist.se> wrote:
>
> forcemerge 41130 41198
> thanks
>
> Yuan Fu <casouri@gmail.com> writes:
>
>> Add two commands that cycles a heading (like that in Org mode) in
>> outline-mode:
>>
>> - outline-cycle: cycles between “hide all”, “sub headings” and “show all”
>> state. They are called “FOLDED”, “CHILDREN”, “SUBTREE” in Org mode.
>> - outline-cycle-buffer: cycles between “only top level headings”, “all
>> headings”, “show all” states
>
> Thanks for working on this. I've tested your patch, and it seems to
> work as advertised.
Thanks.
>
>> Could this be useful?
>
> I think it could. I have previously sent the wishlist Bug#41130, which
> I have now merged with this bug. I have seen no objections to that
> proposal, so I hope that it is uncontroversial.
>
> In Bug#41130, I also suggest to add the same keybinding as in org-mode:
> TAB and S-TAB. Could you add such keybindings to outline-mode-map in
> your patch?
It seems that the outline-mode bindings all live under C-c. Maybe C-c TAB and
C-c S-TAB? Should I ask on emacs-devel for for suggestions?
>
> I think we also need ChangeLog in the commit message, an entry in NEWS,
> and updates to the manual.
I updated NEWS and the manual. For ChangeLog, I thought that’s automatically
generated from commit messages?
>
>> +(defun outline-cycle ()
>> + "Cycle between “hide all”, “headings only” and “show all”.
>> +
>> +“Hide all” means hide all subheadings and their bodies.
>> +“Headings only” means show sub headings but not their bodies.
>> +“Show all” means show all subheadings and their bodies."
>
> I can't remember seeing double quotes used like that before in doc
> strings. Correct me if I'm wrong, but wouldn't we normally use
> `single-quotes' for something like this?
>
Done.
Yuan
outline.patch
Description: Binary data