bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#41385: [PATCH] Show eww bookmarks buffer only if it's not empty


From: Stefan Kangas
Subject: bug#41385: [PATCH] Show eww bookmarks buffer only if it's not empty
Date: Tue, 19 May 2020 20:44:30 -0700

Lars Ingebrigtsen <larsi@gnus.org> writes:

> I don't think this is an ideal way to fix this command -- using error
> handling to do control flow is usually the wrong thing to do, and it
> makes debugging difficult.  What if there's a real bug in
> eww-bookmark-prepare?
>
> Instead eww-list-bookmarks should just do the
>
>   (eww-read-bookmarks)
>   (unless eww-bookmarks
>     (user-error "No bookmarks are defined"))
>
> bit, I think.  It might mean rearranging some stuff in eww-next-bookmark
> etc, though.

Thanks, good point.  Does the attached patch look better?

Best regards,
Stefan Kangas

Attachment: 0001-Show-eww-bookmarks-buffer-only-if-it-s-not-empty.patch
Description: Text Data


reply via email to

[Prev in Thread] Current Thread [Next in Thread]