bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#41242: Port feature/native-comp to Windows


From: Nicolas Bértolo
Subject: bug#41242: Port feature/native-comp to Windows
Date: Wed, 20 May 2020 15:48:52 -0300

> This won't compile on Posix because setjmp_ctx_func is under #ifdef
> _WIN32.

Fixed.

> Given setjmp_ctx_func is used only in emit_setjmp I suggest to invoke
> directly gcc_jit_context_get_builtin_function there while emitting the
> corresponding call.

Done.

> The following patches do not currently apply, please update them from
> your rebase branch:

> 0004-Handle-LISP_WORDS_ARE_POINTERS-and-CHECK_LISP_OBJECT.patch
> 0005-Remove-a-layer-of-indirection-for-access-to-pure-sto.patch

Done.

> While you are refreshing patches please have a look into the GNU style
> of the diff (spaces in function calls and in pointer declaration) ;)

Fixed :).

> Sorry, still looking at
> 0003-Handle-setjmp-taking-two-arguments-in-Windows.patch forgot to ask
> if you could comment on this change:
> >                                     comp.char_type,
> > -                                   sizeof (jmp_buf)),
> > +                                   sizeof (sys_jmp_buf)),

It is just a little bit more portable.

I uploaded new patches to https://github.com/nicber/emacs branch
feature/native-comp. Please tell me I if you'd rather I posted patches here.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]