[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#41544: 26.3; Possible incorrect results from color-distance
From: |
Mattias Engdegård |
Subject: |
bug#41544: 26.3; Possible incorrect results from color-distance |
Date: |
Wed, 10 Jun 2020 20:29:37 +0200 |
10 juni 2020 kl. 17.08 skrev Eli Zaretskii <eliz@gnu.org>:
> Please make sure the doc string says that the function will return
> either the black or the white color, depending on which one will
> contrast better with COLOR. Otherwise it is impossible to know,
> without looking at the code, that this function can return only these
> two colors.
A good suggestion -- followed.
> Other than that, I'm okay with the following parts of your patch:
>
> . the changes in list-colors-print
> . the addition of color-dark-p and the change in
> readable-foreground-color to use it
> . the replacement of css--contrasty-color with
> readable-foreground-color (assuming Tom doesn't object)
Thank you, pushed to master. It does not prevent extended use later on.
Would still like a better reason for it than a curt dismissal without any
technical argument whatsoever other than a general aversion to change. The
proposed code is likely considerably better researched and tested than what it
aimed to replace ever was.
- bug#41544: 26.3; Possible incorrect results from color-distance, (continued)
- bug#41544: 26.3; Possible incorrect results from color-distance, Drew Adams, 2020/06/07
- bug#41544: 26.3; Possible incorrect results from color-distance, Simen Heggestøyl, 2020/06/07
- bug#41544: 26.3; Possible incorrect results from color-distance, Mattias Engdegård, 2020/06/08
- bug#41544: 26.3; Possible incorrect results from color-distance, Drew Adams, 2020/06/08
- bug#41544: 26.3; Possible incorrect results from color-distance, Mattias Engdegård, 2020/06/08
- bug#41544: 26.3; Possible incorrect results from color-distance, Drew Adams, 2020/06/10
- bug#41544: 26.3; Possible incorrect results from color-distance, Mattias Engdegård, 2020/06/10
- bug#41544: 26.3; Possible incorrect results from color-distance, Eli Zaretskii, 2020/06/09
- bug#41544: 26.3; Possible incorrect results from color-distance, Mattias Engdegård, 2020/06/10
- bug#41544: 26.3; Possible incorrect results from color-distance, Eli Zaretskii, 2020/06/10
- bug#41544: 26.3; Possible incorrect results from color-distance,
Mattias Engdegård <=
- bug#41544: 26.3; Possible incorrect results from color-distance, Eli Zaretskii, 2020/06/10
- bug#41544: 26.3; Possible incorrect results from color-distance, Simon Pugnet, 2020/06/04
- bug#41544: 26.3; Possible incorrect results from color-distance, Mattias Engdegård, 2020/06/04
bug#41544: 26.3; Possible incorrect results from color-distance, Basil L. Contovounesios, 2020/06/01