[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#41808: 28.0.50; Various battery.el improvements
From: |
Basil L. Contovounesios |
Subject: |
bug#41808: 28.0.50; Various battery.el improvements |
Date: |
Thu, 11 Jun 2020 18:22:22 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) |
Eli Zaretskii <eliz@gnu.org> writes:
>> From: "Basil L. Contovounesios" <contovob@tcd.ie>
>> Date: Thu, 11 Jun 2020 16:47:40 +0100
>> Cc: mattias engdegÄrd <mattiase@acm.org>
>>
>> - ((fboundp 'w32-battery-status)
>> + ((functionp 'w32-battery-status)
>> #'w32-battery-status))
>
> Is something wrong with fboundp? I think we have dozens if not
> hundreds of such uses of fboundp, so if something's wrong with it, we
> had better fixed them all.
The only reason I switched to functionp is because
battery-status-function is passed to funcall, but now that I think about
it again we're only checking whether the definition exists at all here,
so I reverted to fboundp.
Thanks,
--
Basil