[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#41684: [PATCH] Highlight typed variables in python
From: |
Konstantin Kharlamov |
Subject: |
bug#41684: [PATCH] Highlight typed variables in python |
Date: |
Sat, 13 Jun 2020 11:57:44 +0300 |
User-agent: |
Evolution 3.36.3 |
On Sat, 2020-06-13 at 10:35 +0300, Eli Zaretskii wrote:
> > From: Konstantin Kharlamov <Hi-Angel@yandex.ru>
> > Date: Wed, 3 Jun 2020 14:51:03 +0300
> >
> > * progmodes/python.el (python-font-lock-keywords-maximum-
> > decoration):
> > recognize typed variables like "foo: int = 1" as well.
> > ---
>
> Thanks, I installed this on the master branch.
Thanks!
> For the future, please note a couple of minor stylistic nits:
>
> . it is better to submit patches in "git format-patch" format, as
> that makes it easier to apply the patch
Hmm, okay… The patch was sent with git-send-email command, is it
different from git-format-patch? I used to see projects that in our
days still use (or have used) email for patches recommend specifically
sending patches with git-send-email, so it is a bit unusual
requirement, but I'll try to remember.
> . the description in the log message should start with a capital
> letter after the function's name
Okay, thanks. I'll try to remember, although it is unusual too, because
AFAIK from grammar standpoint a sentence continuation after a colon ":"
symbol should be lower-case.
> . if a comment or a code line exceeds 80 columns, break them into
> several lines