bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#41858: 28.0.50; [PATCH]: Make project-shell use universal argument


From: Juri Linkov
Subject: bug#41858: 28.0.50; [PATCH]: Make project-shell use universal argument
Date: Tue, 16 Jun 2020 02:01:31 +0300
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu)

> How about we just add this behaviour instead of appending the
> file-path?  so we get the "<n>" appended to the shell buffer names.
> Then you can remove that line from init :)

Thanks, I see you did exactly this in your new patch.

>> Regarding the C-u argument, I don't know maybe someone might want
>> to use it.  But shouldn't the C-u argument of 'project-shell' be
>> more compatible with the C-u argument of 'shell' in its behaviour?
>
> I kind of agree, though it seems like the original "project-shell" was
> intended to be used only interactively. I kind of view it as a specialized
> case of "shell", maybe as a sort of "shell-dwim" but only for a very
> limited case. We are always free of course to add a normal shell buffer in
> root, and use it non-interactively in code.
>
> However, I can add an "&optional buffer" argument to the code and do
> like it's done in "shell".  It just seems like it is complicating the
> behaviour a little bit.  What do you think?

I agree there is no need to complicate "project-shell" with all
idiosyncrasies of "shell".

> I've attached another patch for you to look at, with only the easy
> changes, awaiting some feedback on the other parts :)

I see no more problems with your patch, it seems it covers the needs
of most users, thanks.





reply via email to

[Prev in Thread] Current Thread [Next in Thread]