[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#41879: 28.0.50; [Patch]: Add project-switch-to-buffer in project.el
From: |
Theodor Thornhill |
Subject: |
bug#41879: 28.0.50; [Patch]: Add project-switch-to-buffer in project.el |
Date: |
Tue, 16 Jun 2020 05:45:34 +0000 |
Thanks alot for your comments!
"Dmitry Gutov" <dgutov@yandex.ru> writes:
[...]
> The REQUIRE-MATCH argument should be t, I think.
Done.
> > + (lambda (buffer)
> > + (when-let* ((path (buffer-file-name (cdr buffer)))
[...]
> Call it file or file-name.
Done.
> > + (true (file-truename path)))
>
> Do we need this conversion? It'll add some runtime overhead, and I'm not
> sure in which conditions the result will be different.
I removed it, seems to work fine :).
> > + (when (file-in-directory-p true (project-root pr))
> > + 'buffer)))))))
>
> Why 'buffer and not t?
I just figured it as readable, but t is there now!
Theo
project-switch-to-buffer.patch
Description: Text Data
- bug#41879: 28.0.50; [Patch]: Add project-switch-to-buffer in project.el, Theodor Thornhill, 2020/06/15
- bug#41879: 28.0.50; [Patch]: Add project-switch-to-buffer in project.el, Philip K., 2020/06/15
- bug#41879: 28.0.50; [Patch]: Add project-switch-to-buffer in project.el, Dmitry Gutov, 2020/06/15
- bug#41879: 28.0.50; [Patch]: Add project-switch-to-buffer in project.el, Theodor Thornhill, 2020/06/15
- bug#41879: 28.0.50; [Patch]: Add project-switch-to-buffer in project.el, Dmitry Gutov, 2020/06/15
- bug#41879: 28.0.50; [Patch]: Add project-switch-to-buffer in project.el,
Theodor Thornhill <=
- bug#41879: 28.0.50; [Patch]: Add project-switch-to-buffer in project.el, Philip K., 2020/06/16
- bug#41879: 28.0.50; [Patch]: Add project-switch-to-buffer in project.el, Theodor Thornhill, 2020/06/16
- bug#41879: 28.0.50; [Patch]: Add project-switch-to-buffer in project.el, Basil L. Contovounesios, 2020/06/16
- bug#41879: 28.0.50; [Patch]: Add project-switch-to-buffer in project.el, Theodor Thornhill, 2020/06/16
- bug#41879: 28.0.50; [Patch]: Add project-switch-to-buffer in project.el, Basil L. Contovounesios, 2020/06/16
- bug#41879: 28.0.50; [Patch]: Add project-switch-to-buffer in project.el, Theodor Thornhill, 2020/06/16
- bug#41879: 28.0.50; [Patch]: Add project-switch-to-buffer in project.el, Basil L. Contovounesios, 2020/06/16
- bug#41879: 28.0.50; [Patch]: Add project-switch-to-buffer in project.el, Theodor Thornhill, 2020/06/16
- bug#41879: 28.0.50; [Patch]: Add project-switch-to-buffer in project.el, Basil L. Contovounesios, 2020/06/16
- bug#41879: 28.0.50; [Patch]: Add project-switch-to-buffer in project.el, Dmitry Gutov, 2020/06/16