[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#41890: 28.0.50; [PATCH]: Add bindings for project.el
From: |
Basil L. Contovounesios |
Subject: |
bug#41890: 28.0.50; [PATCH]: Add bindings for project.el |
Date: |
Tue, 16 Jun 2020 21:31:53 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) |
Theodor Thornhill <theo@thornhill.no> writes:
>> This should be:
>>
>> (defvar project-prefix-map
>> (let ((map (make-sparse-keymap)))
>> (define-key map ...)
>> ...
>> map)
>> "...")
>>
>> (define-key ctl-x-map "p" project-prefix-map)
>>
>> See the end of (info "(elisp) Tips for Defining").
>>
>> Maybe it should also be autoloaded.
>
> Below is another patch with your suggestions incorporated. Is it correct to
> also
> autoload the (define-key ctl-x-map "p" project-prefix-map)?
I'm not an autoload expert, so I'd appreciate if someone else chimed in,
but according to the commentary in lisp/bookmark.el,
;;;###autoload (define-key ...)
is preferable to
;;;###autoload
(define-key ...)
since the former is copied to lisp/ldefs-boot.el at build time and
skipped at load time (since it's in a comment), so it doesn't override
existing user settings. Would that do what we want?
Thanks,
--
Basil
- bug#41890: 28.0.50; [PATCH]: Add bindings for project.el, (continued)
- bug#41890: 28.0.50; [PATCH]: Add bindings for project.el, Dmitry Gutov, 2020/06/17
- bug#41890: 28.0.50; [PATCH]: Add bindings for project.el, Juri Linkov, 2020/06/17
- bug#41890: 28.0.50; [PATCH]: Add bindings for project.el, Dmitry Gutov, 2020/06/17
- bug#41890: 28.0.50; [PATCH]: Add bindings for project.el, Juri Linkov, 2020/06/17
- bug#41890: 28.0.50; [PATCH]: Add bindings for project.el, Dmitry Gutov, 2020/06/17
- bug#41890: 28.0.50; [PATCH]: Add bindings for project.el, Juri Linkov, 2020/06/18
- bug#41890: 28.0.50; [PATCH]: Add bindings for project.el, Dmitry Gutov, 2020/06/18
- bug#41890: 28.0.50; [PATCH]: Add bindings for project.el, Juri Linkov, 2020/06/20
- bug#41890: 28.0.50; [PATCH]: Add bindings for project.el, Dmitry Gutov, 2020/06/20
- bug#41890: 28.0.50; [PATCH]: Add bindings for project.el, Philip K., 2020/06/17
- bug#41890: 28.0.50; [PATCH]: Add bindings for project.el,
Basil L. Contovounesios <=
- bug#41890: 28.0.50; [PATCH]: Add bindings for project.el, Theodor Thornhill, 2020/06/17
- bug#41890: 28.0.50; [PATCH]: Add bindings for project.el, Basil L. Contovounesios, 2020/06/17
- bug#41890: 28.0.50; [PATCH]: Add bindings for project.el, Dmitry Gutov, 2020/06/17
- bug#41890: 28.0.50; [PATCH]: Add bindings for project.el, Dmitry Gutov, 2020/06/16
- bug#41890: 28.0.50; [PATCH]: Add bindings for project.el, Dmitry Gutov, 2020/06/16
- bug#41890: 28.0.50; [PATCH]: Add bindings for project.el, Eli Zaretskii, 2020/06/17
- bug#41890: 28.0.50; [PATCH]: Add bindings for project.el, Eli Zaretskii, 2020/06/17
- bug#41890: 28.0.50; [PATCH]: Add bindings for project.el, Dmitry Gutov, 2020/06/17
- bug#41890: 28.0.50; [PATCH]: Add bindings for project.el, Eli Zaretskii, 2020/06/17
- bug#41890: 28.0.50; [PATCH]: Add bindings for project.el, Dmitry Gutov, 2020/06/17